Fix ctx timeout for node connect during nodes sync pipeline #1637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sitole
changed the title
sitole
requested review from
ValentaTomas,
dobrac and
jakubno
as code owners
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
For local and cluster nodes we have now context created for each async run. This will not timeout whole sync pipeline when node connect takes 20 seconds (pipeline ctx timeout). Limit is set for each async execution.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
We were creating new instance of ctx with span called spanCtx. This is not needed as original ctx is not ment to be used again so we can just re-assign already existing ctx var.
sitole
force-pushed
the
fix/ctx-timeout-for-node-connect
branch
from
379899f to
1879a28
Compare
jakubno
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Introduce 5s per-node connect timeouts and unify context/trace usage so slow node connections don’t stall the sync loop.
packages/api/internal/orchestrator/cache.go)nodeConnectTimeout(5s) and wrap per-node connects withcontext.WithTimeoutinsyncLocalDiscoveredNodesandsyncClusterDiscoveredNodesto avoid blocking the sync cycle.ctxfromtracer.Start(...)acrosssyncNodes,syncLocalDiscoveredNodes,syncClusterDiscoveredNodes, and syncing existing nodes; update error logs to use the samectx.context.WithoutCancel(ctx)and deregister the node.Written by Cursor Bugbot for commit f396e39. This will update automatically on new commits. Configure here.