Build system: Added mountpoint to the provisioning script #1648
+98
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mishushakov
requested review from
ValentaTomas,
dobrac and
jakubno
as code owners
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
packages/orchestrator/internal/template/build/phases/base/provision.sh
Outdated
Show resolved
Hide resolved
packages/orchestrator/internal/template/build/phases/base/provision.sh
Outdated
Show resolved
Hide resolved
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
packages/orchestrator/internal/template/build/phases/base/provision.sh
Outdated
Show resolved
Hide resolved
jakubno
requested changes
Dec 24, 2025
packages/orchestrator/internal/template/build/phases/base/provision.sh
Outdated
Show resolved
Hide resolved
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
tests/integration/internal/tests/api/templates/build_template_test.go
Outdated
Show resolved
Hide resolved
dobrac
approved these changes
Dec 29, 2025
jakubno
approved these changes
Dec 29, 2025
mishushakov
deleted the
enable-mounting-volumes-via-mountpoint-using-sdk-eng-3407
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to mount S3 buckets via mountpoint in the Sandboxes we need to make sure mountpoint is available in userspace.
Note
Introduces
mount-s3support in the base provisioning and validates it via integration tests.provision.shto addfuse3, detect architecture, and installmount-s3from Mountpoint’s release URL if missingis_package_installedto avoid redundant installsmount-s3links tolibfuse.soand reports a versionWritten by Cursor Bugbot for commit 25880d9. This will update automatically on new commits. Configure here.