Skip to content

Conversation

@ValentaTomas
Copy link
Member

@ValentaTomas ValentaTomas commented Dec 30, 2025

Note

Enforces kernel read/write limits during process-memory copy and adds coverage.

  • Update copyProcessMemory to split input ranges with splitOversizedRanges, batching unix.RemoteIovec up to IOV_MAX and total bytes up to MAX_RW_COUNT, tracking offset correctly when marking dirty blocks
  • Introduce constants in iov.go (PAGE_SIZE, PAGE_MASK, INT_MAX, MAX_RW_COUNT) to cap per-call bytes
  • Add splitOversizedRanges helper and comprehensive unit tests, plus a regression test that copies data exceeding MAX_RW_COUNT without errors

Written by Cursor Bugbot for commit 845c117. This will update automatically on new commits. Configure here.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ValentaTomas ValentaTomas enabled auto-merge (squash) December 30, 2025 16:04
@ValentaTomas ValentaTomas enabled auto-merge (squash) December 30, 2025 16:35
@ValentaTomas ValentaTomas merged commit b635821 into main Dec 30, 2025
49 of 50 checks passed
@ValentaTomas ValentaTomas deleted the fix-k-copy branch December 30, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants