Transparently check if template alias exists #1678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to add separated template that accepts only template alias (not id) and transparently shows difference between 404 (you are owner and template does not exists) and 403 (you are not owner but template exists). This way we can use this endpoint in services to check if alias is available. We cannot do that with existing endpoints as they are returning 404 for both forbidden and not found cases.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Use test containers so we can run API service and test everything end to end with Postgres database running in container. This way we can run debugger and test all cases locally.
This comment was marked as outdated.
This comment was marked as outdated.
Moved onetime used functions for tema and template creation to database test utils package. This way they can be re-used.
Replace local copy of test helper utils with database package utils implementation.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 75c1e41ced
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
jakubno
requested changes
Jan 7, 2026
jakubno
requested changes
Jan 7, 2026
jakubno
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to add separated template that accepts only template alias (not
id) and transparently shows difference between 404 (you are owner and
template does not exists) and 403 (you are not owner but template
exists).
Note
Adds a dedicated endpoint to resolve templates by alias and wires it through the server interface and router.
GET /templates/aliases/{alias}route withGetTemplatesAliasesAliashandler and middleware inapi.gen.go/templates/aliases/:aliasgeneratenow also producesinternal/api/client.gen.goWritten by Cursor Bugbot for commit 8fc7c16. This will update automatically on new commits. Configure here.