fix(analytics): guard long-running sandboxes and set proper report timeout #1686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaninyzwitty
requested review from
ValentaTomas,
dobrac and
jakubno
as code owners
jakubno
requested changes
Jan 7, 2026
| if sandbox.StartTime.IsZero() { | ||
| continue | ||
| } | ||
| if now.Sub(sandbox.StartTime) > oldSandboxThreshold { |
Member
There was a problem hiding this comment.
can we keep
time.Since(sandbox.StartTime) > oldSandboxThreshold
I think it's more readable and the improvement is negligible
Comment on lines
43
to
45
| if sandbox.StartTime.IsZero() { | ||
| continue | ||
| } |
jakubno
requested changes
Jan 9, 2026
Comment on lines
63
to
64
| instanceIds := make([]string, 0, len(instances)) | ||
| executionIds := make([]string, 0, len(instances)) |
Member
There was a problem hiding this comment.
We know the length will be exactly instances, so it's seems to be safe to preallocate and do it as it is now. What was the reason behind this change?
Contributor
Author
There was a problem hiding this comment.
Well ok — given your current logic always appends exactly one entry per instance, this change doesn’t add much value. I will revert it to keep the code simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nowtimestamp for consistent evaluation within each ticksyncAnalyticsTimewithreportTimeoutfor analytics request context