Repository navigation
fix(mobile): reject a null device provider with INVALID_CONFIG, list the config and mobileTools errors - #1619
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
okwasniewski
left a comment
There was a problem hiding this comment.
Automated review (agent-run triage).
Every documented error checks out against main: blank/non-string list entries via namedDevice (pool.ts:83), device: 42 failing with "non-empty name", the provider acquire/release/record checks, mobileTools(web()) -> INVALID_STATE wrapped as CONFIG_LOAD_FAILED (config/load.ts:153), the Tool "<name>" failed: prefix (default-agent.ts:201), and the open_app codes (INVALID_STATE / INVALID_ARGUMENT / POLICY_DENIED). No invented codes. CI green.
Should fix
- The PR also changes code:
provider.ts:151getsdevice ?? {}plus a changeset. Retitle tofix(mobile): ...so the changelog and policy check read it right. asDeviceProvider(device: object)now handlesnull, so type the parameterunknowninstead of??on a non-nullable type.
Nits
docs/reference/mobile.mdx:916: "No device attempt is running in the worker, or more than one is" leans on internals. Something like "called outside a test, or while several devices are open" reads better for users.- Row 1 "not a non-blank string" is a double negative. "A blank or non-string list entry".
|
Thanks. Retitled to |
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
|
@okwasniewski the retitle, the |
|
[claude-opus-5-5] automated review on behalf of @okwasniewski Re-review of 2c781ae: all asks are done.
The pr-policy check only wants a linked issue for a The red This was an automated review. |
Asks addressed in 3ec5e78/1e87c01ca (automated review)
|
Added |
|
[claude-opus-5-5] automated review on behalf of @okwasniewski Re-check of a9963f2: |
okwasniewski
left a comment
There was a problem hiding this comment.
Automated review: approved, see comment.
What and why
devicelist; a blank device name and a malformed device provider also fail withINVALID_CONFIGat config load.mobileToolshad no Throws entry: passing a non-mobile()engine fails the config load, andopen_appand the other tools have failure modes the model sees.Issue
Fixes #1629
Verified
Ran it locally: yes
e2e listwith a blankdevice, a provider missingrelease, a provider withoutname,device: 42, andmobileTools(web()): each message and code matches its row.pnpm checkgreen;@e2e-dev/mobiletools, provider and engine unit tests pass (268).guardedToolsindefault-agent.tsand the unit tests intools.test.ts.Checklist
pnpm changeset) for any change to a published package, or the change is testbed, docs, or CI only.!, the changeset body names what breaks and what replaces it, and the deprecation warning landed a window earlier (stability policy in CONTRIBUTING.md).docs/**/*.mdxpage for the behavior, andskills/e2e/if the skill describes it..d.tsreviewed,tests/types/sdk-types.tsupdated; wire change edits the schema and both fixtures.e2e/engine): changesets fore2e,@e2e-dev/web, and@e2e-dev/mobile.