Repository navigation
fix(locator): include deadline setup in waitFor elapsed time - #1635
Closed
okwasniewski wants to merge 2 commits into
Closed
okwasniewski wants to merge 2 commits into
okwasniewski wants to merge 2 commits into
Conversation
Starting the elapsed timer after creating the deadline can report 299 ms for a 300 ms wait when setup crosses a millisecond boundary. Record the start first and cover the boundary deterministically without changing polling or weakening failure-evidence assertions.
Contributor
🟢 e2e web: 91 passedAll 91 tests in 41 files
Tested by e2e 0.23.0 · 59.5s · web · run artifacts |
Contributor
🟢 e2e web agent: 33 passed34 agent steps · 26 replayed from cache · 20 model calls · 87.7k tokens (94% cached) · $0.0035 All 33 tests in 5 files
Tested by e2e 0.23.0 · 1m 23s · web · run artifacts |
Contributor
🟢 e2e ios agent: 21 passed, 1 skipped25 agent steps · 12 replayed from cache · 58 model calls · 362.7k tokens (82% cached) · $0.0242 All 22 tests in 1 file
Tested by e2e 0.23.0 · 8m 35s · ios-simulator · run artifacts |
Contributor
🟢 e2e android agent: 20 passed24 agent steps · 15 replayed from cache · 49 model calls · 332.0k tokens (80% cached) · $0.0242 All 20 tests in 1 file
Tested by e2e 0.23.0 · 5m 0s · android-emulator · run artifacts |
Contributor
🟢 e2e android: 57 passed, 1 skippedAll 58 tests in 7 files
Tested by e2e 0.23.0 · 7m 6s · android-emulator · run artifacts |
Contributor
🟢 e2e ios: 55 passed, 1 skippedAll 56 tests in 7 files
Tested by e2e 0.23.0 · 6m 19s · ios-simulator · run artifacts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
waitForbefore constructing its deadline. Previously, crossing a millisecond boundary during setup made a 300 ms wait report 299 ms.Issue
Addresses the Node 22.22.3 failure in https://github.com/tester-army/e2e/actions/runs/42445682374/job/128623992220 on main
a016b3e4e99f0ad09a2466221740d244241f602f. Reproduced against mainc9783a0666ffea9af4d156d1154657fb94b4af1b, whose latest CI passed. The separate screenshot-navigation failure is covered by existing PR #1614.Verified
Ran it locally: yes
waitedMs: 299instead of 300The integration suite uses the built runner and validates the emitted failure evidence and reports. The deterministic regression ran against unchanged main source before the fix. Independent T3 review found no issues and independently reran the 22 unit tests. The final post-review run passed all 30 focused unit and integration tests.
The built CLI also passed the Chromium testbed forms suite:
Full
pnpm testpassed, including 4,307 core tests, 723 web tests, the remaining packages, and 140 script tests. Core and web each retain one existing skip.Full
pnpm checkpassed, including lint, dead-code, builds, all package typechecks, documentation, changesets, plugins, and MCP metadata.Full
pnpm --filter @e2e-dev/testbed testalso passed before opening this PR.Checklist
e2e.docs/reference/screen.mdx; the consumer skill does not describewaitedMs.Verification after merging #1614
Merged main at
f6aba97257700339b60fb67722178d23ee2c5f93into this branch without rewriting published history. The previous web-agent failure matched #1614's infinite-scroll bug: scrolling stopped at item 60 while more items were loading.The unchanged committed recording now passes locally with strict replay:
Rebuilt all packages and the benchmark app. All 50 focused core tests passed across locator waits, failure evidence, and scroll behavior; all 6 screenshot-navigation tests passed. No recording was replaced. CI has finished for the merge commit; see the remaining failure below.
Remaining CI failure
The Node 22.22.3 job passed all 314 core test files, including the original failure-evidence case, then failed
packages/acp/tests/executor.test.ts:522:retries the session directory removal after the agent exits when the first try fails. Its fake agent had already exited at the 500 ms liveness check (kill ESRCH). This ACP code is unchanged by this PR and came from #1626.The focused ACP test passes locally on both Node 24.19.0 and Node 22.22.3. The full ACP suite also passes locally on Node 22.22.3, all 39 tests. These runs were on macOS; the CI failure was on Linux. The cause of the early child exit has not been reproduced or established. No assertion was weakened and no CI retry was requested to hide it. This PR is not yet green.
All web and mobile benchmark jobs passed on
1b8e421: web 91, web agent 33, Android 57 plus one documented skip, Android agent 20, iOS 55 plus one documented skip, and iOS agent 21 plus one documented skip. No checks remain pending. The Node 22.22.3 ACP cleanup test and its dependent spec gate are the only failed checks. No review threads are open. The PR has not been labeled Ready for Human Review because that failure remains unresolved.