Skip to content

fix(security): redact tool outputs and patch vulnerable dependencies - #1715

Merged
okwasniewski merged 5 commits into
mainfrom
t3/fix-dependabot-security-alerts
Nov 12, 2026
Merged

okwasniewski merged 5 commits into
mainfrom
t3/fix-dependabot-security-alerts

Conversation

@okwasniewski

@okwasniewski okwasniewski commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

What and why

  • Resolve the seven dependency alerts with scoped overrides for fast-uri, @hono/node-server, glob, and minimatch.
  • Redact project-tool results, serialized JSON, custom toModelOutput text, and tool/engine errors before model input. Redact strings before truncation, and apply the live secret ledger to AI trace names, scope metadata, input, and output.
  • Redact and bound collection-time and runtime skip reasons before reporters receive them, including skips beside an existing failure.
  • Remove polynomial regex scanning from stack-frame parsing and provider endpoint trimming; retain single-slash file URL support. Preserve ACP forwarding failures in the runner's redacted diagnostics while keeping exception text out of HTTP responses. Normal client disconnects remain harmless.
  • Add regression coverage, documentation, consumer-skill updates, and patch changesets.
flowchart LR
  T[Tool output] --> S[Serialize custom JSON output]
  S --> R[Redact provider input]
  T --> A[Serialize and redact AI trace]
Loading

Issue

  • Maintainer-requested security cleanup. Private reports remain tracked in the repository's Security tab.
  • Web redirect-header reports and three test-fixture scanning findings remain outside this PR. No GitHub alerts or advisories were dismissed.

Verified

Ran it locally: yes

  • Built the packages and ran the same new tool-output, skip-reason, and AI-trace regression tests against a source archive of current main and this branch.
main this branch
Tool-output regression fails Passes, including null-prototype dictionaries, URL serialization, and custom output callbacks
Skip-reason regression fails report-schema validation Passes; JSON, Markdown, and JUnit contain redacted, bounded reasons
AI-trace redaction regression fails Passes with the live ledger applied during serialization
ACP forwarding exceptions are sent in the HTTP response The HTTP response stays generic; the runner stops the session and reports the redacted cause
pnpm audit reports seven advisories Zero vulnerabilities
  • Ran the built CLI in a scratch project with a custom tool returning a URL, another throwing an error, and --ai-trace. The fake provider rejects raw sentinel values. unbox-ai found the redacted marker in the trace and no raw sentinel matches.
✓ redacts custom tools and trace > agent.act "read both tools" · 2 model calls
Test Files  1 passed (1)
     Tests  1 passed (1)
  • pnpm check; 55 focused core tests cover the final review changes. The preceding full core run passed 4,584 tests with 11 skipped. GitHub, ACP, BrowserStack, and TestMu suites also passed. Public declaration comparison: all 25 files unchanged.
  • All 47 ACP tests passed, including real HTTP streaming/disconnect tests and startup/active-turn error propagation. A built-CLI failure probe confirmed the cause appears in terminal and JSON output with its synthetic secret redacted.
MODEL_PROVIDER_FAILED: The ACP agent session failed: step-tool request forwarding failed: <secret:unsupportedMethod> HTTP method is unsupported.
  • Full testbed through the built CLI: 588 passed, 1 skipped. Deterministic web benchmark: 91 passed.
  • Expo fingerprint generation succeeded with the updated glob dependencies; the patched Hono server passed a request/response smoke test.

Checklist

  • Changeset added for published-package changes.
  • Breaking change: not applicable.
  • Matching docs and consumer skill updated.
  • Public API or wire contract change: not applicable.
  • Engine contract change: not applicable.

@github-actions github-actions Bot added the size:L Up to 499 changed lines, not counting tests, fixtures, translated docs, or the lockfile label Nov 12, 2026
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

🟢 e2e web: 91 passed

All 91 tests in 41 files
Test Time
🟢 tests/aria-hidden-flow.e2e.ts · 2 passed 775ms
🟢 aria hidden flow › picks the Pro plan by its visible text and confirms it 560ms
🟢 aria hidden flow › another plan shows the error and keeps the picker open 215ms
🟢 tests/async-states.e2e.ts · 2 passed 7.0s
🟢 async states › reads the code off the transient toast and verifies it once the button enables 2.2s
🟢 async states › a wrong code is rejected after the toast has gone 4.8s
🟢 tests/canvas-only.e2e.ts · 2 passed 332ms
🟢 canvas only › taps square, circle, then diamond at their pixel coordinates 177ms
🟢 canvas only › a shape out of order paints the error and resets progress 155ms
🟢 tests/canvas-whiteboard.e2e.ts · 2 passed 443ms
🟢 canvas whiteboard › drags both shapes into their slots and saves 253ms
🟢 canvas whiteboard › bounces a shape off the wrong slot and refuses to save early 190ms
🟢 tests/cart-totals.e2e.ts · 2 passed 419ms
🟢 cart totals › increasing a quantity updates the line total but the order summary stays stale (planted bug) 246ms
🟢 cart totals › a quantity never drops below one 173ms
🟢 tests/checkout-review.e2e.ts · 1 passed 179ms
🟢 shows a raw greeting token and an undefined delivery date (planted bug), yet places the order 179ms
🟢 tests/context-menu-trap.e2e.ts · 2 passed 685ms
🟢 context menu trap › right-click opens nothing; the row menu renames the file 341ms
🟢 context menu trap › the decoy menu items refuse and keep the file 344ms
🟢 tests/control-inventory.e2e.ts · 8 passed 3.7s
🟢 control inventory › check sets the checkbox and the radio without flipping a set one 278ms
🟢 control inventory › check picks a radio the pick replaces with its summary 158ms
🟢 control inventory › a long press and a double click are told apart from a tap 988ms
🟢 control inventory › the file menu opens on right-click only and Rename renames the file 239ms
🟢 control inventory › setInputFiles attaches files named from the project root 167ms
🟢 control inventory › the details view is left through the browser history 191ms
🟢 control inventory › scrollIntoView brings the footnote into view 293ms
🟢 control inventory › every exercise done shows the success message 1.4s
🟢 tests/css-content-ui.e2e.ts · 2 passed 347ms
🟢 css content ui › the tile labelled Ship it advances and confirming ships 172ms
🟢 css content ui › a wrong tile shows the CSS-rendered error and keeps the picker 175ms
🟢 tests/date-picker.e2e.ts · 2 passed 744ms
🟢 date picker › navigates three months ahead and books the required date 412ms
🟢 date picker › confirming without the exact date shows the error 332ms
🟢 tests/debounced-search.e2e.ts · 2 passed 2.9s
🟢 debounced search › a decoy one character off is refused 1.4s
🟢 debounced search › picking the exact item adds it to the cart 1.4s
🟢 tests/deferred-dialog.e2e.ts · 1 passed 1.1s
🟢 one submit opens one confirm, even when double-clicked 1.1s
🟢 tests/div-soup.e2e.ts · 2 passed 860ms
🟢 div soup › a wrong code is rejected 399ms
🟢 div soup › the right code grants access after the delete tile fixes a typo 461ms
🟢 tests/drag-and-drop.e2e.ts · 2 passed 647ms
🟢 drag and drop › an out-of-order item resets the dropzone 319ms
🟢 drag and drop › dropping Banana then Cherry passes 328ms
🟢 tests/filter-deep-link.e2e.ts · 2 passed 258ms
🟢 filter deep link › filtering writes the query to the URL 147ms
🟢 filter deep link › opening a shared link restores the filter 111ms
🟢 tests/gift-card-purchase.e2e.ts · 3 passed 660ms
🟢 gift card purchase › refuses to buy without an amount 194ms
🟢 gift card purchase › refuses a recipient without an at sign 252ms
🟢 gift card purchase › sends the gift card 214ms
🟢 tests/hover-menu.e2e.ts · 2 passed 493ms
🟢 hover menu › a decoy leaf is refused 215ms
🟢 hover menu › hovering Account, then Billing, reaches Redeem voucher 278ms
🟢 tests/iframe-form.e2e.ts · 2 passed 647ms
🟢 iframe form › a wrong code is refused by the host page 319ms
🟢 iframe form › the code read from one frame applies through the other 328ms
🟢 tests/image-only-ui.e2e.ts · 3 passed 546ms
🟢 image only ui › the icons have no names, so the bare svg locator is ambiguous 138ms
🟢 image only ui › a wrong icon shows the error image and keeps the icons 180ms
🟢 image only ui › tapping the star, then the heart, verifies the icons 228ms
🟢 tests/infinite-scroll.e2e.ts · 1 passed 2.8s
🟢 scrolls the feed until the Golden Ticket loads, then claims it 2.8s
🟢 tests/kanban-board.e2e.ts · 3 passed 765ms
🟢 kanban board › pointer drags move both cards into the goal layout 396ms
🟢 kanban board › a swipe along a path drags a card as well 149ms
🟢 kanban board › a plain tap moves nothing and the untouched board is rejected 220ms
🟢 tests/login-form.e2e.ts · 4 passed 847ms
🟢 login form › rejects a malformed email 196ms
🟢 login form › rejects a short password 200ms
🟢 login form › rejects an unknown account 194ms
🟢 login form › signs in and logs out 257ms
🟢 tests/lying-labels.e2e.ts · 4 passed 657ms
🟢 lying labels › the button whose accessible name says Pay now is the wrong one 174ms
🟢 lying labels › a text match for Pay now catches the decoy phrase too 106ms
🟢 lying labels › the field whose accessible name says Amount is the wrong one 176ms
🟢 lying labels › visible text drives the payment through 201ms
🟢 tests/native-dialogs.e2e.ts · 3 passed 467ms
🟢 native dialogs › answers the confirm, prompt, and alert chain 166ms
🟢 native dialogs › dismissing the confirm cancels the order 150ms
🟢 native dialogs › a wrong gift code is rejected 151ms
🟢 tests/newsletter-signup.e2e.ts · 1 passed 2.2s
🟢 subscribe renders no feedback and logs a TypeError (planted bug) 2.2s
🟢 tests/onboarding-wizard.e2e.ts · 5 passed 5.0s
🟢 onboarding wizard › back keeps what was typed and the brief comes back with it 352ms
🟢 onboarding wizard › the address step takes the brief through its bare-div dropdown 389ms
🟢 onboarding wizard › the profile step steers the calendar three decades back 1.3s
🟢 onboarding wizard › the preferences step flips the toggles the brief names and leaves the trap off 1.5s
🟢 onboarding wizard › the review step repeats the brief and finishes with the PIN 1.4s
🟢 tests/order-history.e2e.ts · 2 passed 1.5s
🟢 order history › overview and settings render their panels 220ms
🟢 order history › the orders tab never leaves its loading state (planted bug) 1.3s
🟢 tests/otp-auto-advance.e2e.ts · 3 passed 1.4s
🟢 otp auto-advance › focus advances with each digit and the full code verifies 468ms
🟢 otp auto-advance › backspace on an empty box clears and refocuses the previous one 147ms
🟢 otp auto-advance › a wrong code clears every box and starts over 789ms
🟢 tests/overlay-trap.e2e.ts · 1 passed 757ms
🟢 continues only after the banner and the overlay are gone 757ms
🟢 tests/playbook-cleanup.e2e.ts · 2 passed 579ms
🟢 playbook cleanup › deleting the draft removes it from an exact-name search 284ms
🟢 playbook cleanup › cancelling the dialog keeps the draft searchable 295ms
🟢 tests/price-sorting.e2e.ts · 3 passed 438ms
🟢 price sorting › opens in the featured order with sale prices struck through 119ms
🟢 price sorting › low to high sorts by the original price, not the paid one (planted bug) 155ms
🟢 price sorting › high to low is the same wrong order reversed (planted bug) 164ms
🟢 tests/product-reviews.e2e.ts · 1 passed 1.2s
🟢 the running-shoe page lists coffee-grinder reviews (planted bug) 1.2s
🟢 tests/promo-storefront.e2e.ts · 1 passed 1.3s
🟢 buys a deal once the promo chrome is out of the way 1.3s
🟢 tests/rich-text-editor.e2e.ts · 2 passed 434ms
🟢 rich text editor › bolding exactly the required word passes the check 213ms
🟢 rich text editor › bold that spills into the previous word fails the check 221ms
🟢 tests/saved-addresses.e2e.ts · 3 passed 542ms
🟢 saved addresses › adds an address and clears the form 185ms
🟢 saved addresses › ignores an add with an empty field 180ms
🟢 saved addresses › delete shows its toast but keeps the address, on retry too (planted bug) 177ms
🟢 tests/shadow-dom-form.e2e.ts · 2 passed 502ms
🟢 shadow DOM form › rejects a wrong access code 250ms
🟢 shadow DOM form › grants access with the code from the hint inside the root 252ms
🟢 tests/smoke.e2e.ts · 1 passed 394ms
🟢 home lists the scenarios and opens one 394ms
🟢 tests/stale-dom.e2e.ts · 1 passed 2.1s
🟢 taps the moving target three times across rebuilds of the list 2.1s
🟢 tests/sticky-chrome.e2e.ts · 1 passed 164ms
🟢 accepts the terms once the button clears the sticky footer 164ms
🟢 tests/virtualized-table.e2e.ts · 1 passed 15.3s
🟢 scrolls the windowed table to the Golden Row and claims it 15.3s
🟢 tests/wishlist.e2e.ts · 2 passed 1.5s
🟢 wishlist › saving toggles the button and the tab badge 230ms
🟢 wishlist › the wishlist tab renders the empty state despite the badge count (planted bug) 1.3s

Tested by e2e 0.23.0 · 1m 4s · web · run artifacts

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

🟢 e2e web agent: 33 passed

35 agent steps · 26 replayed from cache · 21 model calls · 89.4k tokens (93% cached) · $0.0039

All 33 tests in 5 files
Test Agent Time
🟢 tests-agent/control-inventory.e2e.ts · 7 passed 7 steps 7.1s
🟢 control inventory › check sets the checkbox and the radio 1 step 624ms
🟢 control inventory › check picks a radio the pick replaces with its summary 1 step 227ms
🟢 control inventory › a long press and a double click are chosen over a plain tap 1 step 851ms
🟢 control inventory › a right-click opens the file menu and Rename renames the file 1 step 2.5s
🟢 control inventory › upload attaches the named project files 1 step 2.3s
🟢 control inventory › back returns from the details view to the inventory 1 step 233ms
🟢 control inventory › scroll_to brings the footnote into view 1 step 343ms
🟢 tests-agent/login-form.e2e.ts · 1 passed 1 step 325ms
🟢 act signs in with the benchmark account 1 step 325ms
🟢 tests-agent/planted-bugs.e2e.ts · 3 passed 5 steps · 9 calls 11.3s
🟢 cart totals: a judgment catches the stale order summary 2 steps · 4 calls 5.0s
🟢 checkout review: a judgment catches the broken copy 1 step · 1 call 1.3s
🟢 wishlist: a judgment catches the lost saved items 2 steps · 4 calls 4.9s
🟢 tests-agent/scenarios.e2e.ts · 21 passed 21 steps · 12 calls 1m 16s
🟢 act completes shadow-dom-form 1 step · 3 calls 3.6s
🟢 act completes lying-labels 1 step · 3 calls 4.6s
🟢 act completes iframe-form 1 step · 3 calls 4.0s
🟢 act completes infinite-scroll 1 step 4.2s
🟢 act completes virtualized-table 1 step 23.8s
🟢 act completes overlay-trap 1 step 1.1s
🟢 act completes sticky-chrome 1 step 1.0s
🟢 act completes async-states 1 step · 3 calls 6.8s
🟢 act completes debounced-search 1 step 2.5s
🟢 act completes hover-menu 1 step 800ms
🟢 act completes drag-and-drop 1 step 652ms
🟢 act completes kanban-board 1 step 858ms
🟢 act completes context-menu-trap 1 step 2.9s
🟢 act completes stale-dom 1 step 691ms
🟢 act completes otp-auto-advance 1 step 939ms
🟢 act completes date-picker 1 step 1.2s
🟢 act completes rich-text-editor 1 step 11.0s
🟢 act completes playbook-cleanup 1 step 891ms
🟢 act completes promo-storefront 1 step 1.5s
🟢 act completes gift-card-purchase 1 step 2.7s
🟢 act filters the list and the URL carries the filter 1 step 360ms
🟢 tests-agent/unique-cache.e2e.ts · 1 passed 1 step 479ms
🟢 act adds an address with a run-unique label 1 step 479ms

Tested by e2e 0.23.0 · 1m 36s · web · run artifacts

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 26 files

Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread packages/e2e/src/internal/ai-trace.ts Resolved
Comment thread packages/acp/src/mcp.ts Resolved
Comment thread packages/e2e/src/agent/default-agent.ts Resolved
Comment thread packages/e2e/src/internal/source.ts Resolved
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

🟢 e2e ios agent: 21 passed, 1 skipped

25 agent steps · 12 replayed from cache · 56 model calls · 362.2k tokens (83% cached) · $0.0240

All 22 tests in 1 file
Test Agent Time
⏭️ tests-agent/scenarios.e2e.ts · 21 passed, 1 skipped 25 steps · 56 calls 8m 29s
🟢 act completes Login Form 1 step 42.0s
🟢 act completes Infinite Scroll List 1 step 38.3s
🟢 act completes Modal Flow 1 step 9.9s
🟢 act completes Bottom Tabs 1 step 7.4s
🟢 act completes Text Input Variations 1 step 13.8s
🟢 act completes Broken Accessibility 2 steps · 5 calls 24.0s
🟢 act completes Vision Only 2 steps · 6 calls 28.6s
🟢 act completes Gestures 1 step · 6 calls 29.5s
🟢 act completes Async States 1 step · 9 calls 31.1s
🟢 act completes Debounced Search 1 step · 1 call 27.2s
🟢 act completes Flattened Registration Form 2 steps · 1 call 29.4s
🟢 act completes Flattened Login 2 steps · 10 calls 55.2s
🟢 act completes Sticky Chrome Target 1 step 14.6s
🟢 act completes WebView Accessibility 1 step 12.7s
🟢 act completes Permission Prompt 1 step 12.4s
🟢 act completes Photo Picker 1 step · 2 calls 31.0s
🟢 act completes Product Catalog 1 step 10.7s
🟢 act completes Error Recovery 1 step 9.9s
🟢 act completes Choice Controls 1 step · 6 calls 35.3s
🟢 act completes Stripe PaymentSheet 1 step · 10 calls 34.1s
🟢 act completes Apple Pay 1 step 12.2s
⏭️ act completes Apple Pay Billing Address (skipped: the CI simulator's Apple Pay sheet skips the billing-address step, so the scenario cannot be completed there)

Tested by e2e 0.23.0 · 8m 30s · ios-simulator · run artifacts

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 8 files (changes from recent commits).

Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

Requires human review: Auto-approval blocked by 2 unresolved issues from previous reviews.

View guided diff | Turn on auto-fix | Re-trigger cubic

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

🟢 e2e android agent: 20 passed

24 agent steps · 15 replayed from cache · 35 model calls · 187.0k tokens (88% cached) · $0.0102

All 20 tests in 1 file
Test Agent Time
🟢 tests-agent/scenarios.e2e.ts · 20 passed 24 steps · 35 calls 5m 46s
🟢 act completes Login Form 1 step 25.6s
🟢 act completes Infinite Scroll List 1 step 22.8s
🟢 act completes Modal Flow 1 step 11.9s
🟢 act completes Bottom Tabs 1 step 8.3s
🟢 act completes Text Input Variations 1 step 7.0s
🟢 act completes Broken Accessibility 2 steps · 5 calls 13.8s
🟢 act completes Vision Only 2 steps · 1 call 5.8s
🟢 act completes Gestures 1 step · 7 calls 17.8s
🟢 act completes Async States 1 step · 11 calls 23.1s
🟢 act completes Debounced Search 1 step 7.1s
🟢 act completes Huge Virtualized List 1 step 1m 55s
🟢 act completes Flattened Registration Form 2 steps · 1 call 7.9s
🟢 act completes Flattened Login 2 steps · 6 calls 14.5s
🟢 act completes Sticky Chrome Target 1 step 9.3s
🟢 act completes WebView Accessibility 1 step · 4 calls 13.7s
🟢 act completes Permission Prompt 1 step 6.5s
🟢 act completes Product Catalog 1 step 7.8s
🟢 act completes Error Recovery 1 step 9.2s
🟢 act completes Choice Controls 1 step 8.5s
🟢 act completes Sequential Onboarding 1 step 9.7s

Tested by e2e 0.23.0 · 5m 46s · android-emulator · run artifacts

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

🟢 e2e ios: 1 flaky, 54 passed, 1 skipped

⚠️ 1 flaky test passed on a retry

⚠️ device fixture › the clipboard reads back what was written
tests/device-fixture.e2e.ts:50

ASSERTION_FAILED

expected "" to be "e2e clipboard 1794477451743"

  • Screen: dev.e2e.benchmark / Control Inventory

Evidence: screenshot, log

All 56 tests in 7 files
Test Time
⚠️ tests/device-fixture.e2e.ts · 1 flaky, 10 passed 1m 35s
🟢 device fixture › setAppearance flips the color scheme the app reads 13.8s
🟢 device fixture › setOrientation rotates the window the app measures 12.3s
⚠️ device fixture › the clipboard reads back what was written (1 failed attempt first) 7.4s
🟢 device fixture › home leaves the app, openApp brings it back where it was 6.2s
🟢 device fixture › closeApp then openApp relaunches on the home list 8.3s
🟢 device fixture › closeApp leaves the next commands on the same device 11.6s
🟢 device fixture › foregroundApp after closeApp reports the closed session as APP_NOT_OPEN 5.3s
🟢 device fixture › device.back pops the scenario 5.5s
🟢 device fixture › unstable_raw reaches the test session through the raw driver 4.5s
🟢 device fixture › setLocation and clearLocation change what the app reads 10.0s
🟢 device fixture › enrollBiometrics and setBiometrics answer a biometric prompt 9.7s
⏭️ tests/controls.e2e.ts · 23 passed, 1 skipped 3m 4s
🟢 control inventory › a label query resolves a labeled text field 10.4s
🟢 control inventory › a labeled field answers name, display value, value reads, fill, and clear 18.9s
🟢 control inventory › a placeholder query and attribute reads find the field 5.9s
🟢 control inventory › a secure field takes a fill and denies value reads 10.0s
🟢 control inventory › press sends a character and Enter through the soft keyboard 10.3s
🟢 control inventory › a field autofocuses on mount and focus() moves the focus 10.2s
🟢 control inventory › toBeFocused follows the focus 9.4s
🟢 control inventory › a switch checks, unchecks, and reports its state 9.5s
🟢 control inventory › checkbox and radio roles answer getByRole, and a checkbox toggles by tap 7.8s
🟢 control inventory › checkbox and radio roles check, uncheck, and report their state 12.8s
🟢 control inventory › a radio group reports the checked option 9.0s
🟢 control inventory › buttons report disabled, enabled, and a state that arrives later 8.0s
🟢 control inventory › a display: none element is absent rather than hidden, its visible twin attached 7.4s
🟢 control inventory › a header answers its accessible name 4.3s
🟢 control inventory › a tab row answers count, all, texts, filters, positions, and switching 6.1s
🟢 control inventory › a list answers counts, list-form text, reads, and boxes in order 6.9s
⏭️ control inventory › a row contains its texts (skipped: React Native flattens a plain View out of the accessibility tree on both platforms: XCTest and the Android helper report a View with a testID as a leaf beside its children, so filter({ has }) and a query scoped to it match nothing; only Sc…)
🟢 control inventory › a long press lands as one 8.5s
🟢 control inventory › pointer verbs land at the point asked for 9.4s
🟢 control inventory › an ambiguous locator fails at once 6.0s
🟢 control inventory › screenshot, restart, and clearState reopen the app on its home list 12.1s
🟢 refusals › verbs a device never declares are refused before the engine 2ms
🟢 refusals › keys the soft keyboard cannot send are refused by the engine 405ms
🟢 refusals › a missing locator fails as not found once its timeout passes 1.1s
🟢 tests/device.e2e.ts · 3 passed 1m 8s
🟢 sequential onboarding echoes the exact values 41.4s
🟢 onboarding rejects a malformed email before advancing 14.3s
🟢 dismissing the keyboard over choice controls leaves them as they were 12.3s
🟢 tests/flows-lists.e2e.ts · 7 passed 4m 27s
🟢 infinite scroll reaches the target item 36.4s
🟢 product catalog adds exactly two of the right variant 11.4s
🟢 gestures: long-press, then swipe left 9.1s
🟢 sticky chrome: accept below the fold, then continue 13.0s
🟢 async states: load, pull to refresh, claim through the toast 12.1s
🟢 huge virtualized list reaches row 512 2m 51s
🟢 web view coupon form applies the code shown on the page 13.3s
🟢 tests/flows.e2e.ts · 7 passed 1m 11s
🟢 text inputs unlock the submit button 13.3s
🟢 filled text inputs report their values 10.3s
🟢 modal flow confirms through the native alert 10.6s
🟢 bottom tabs act inside the last tab 7.9s
🟢 error recovery retries, then confirms the delete 9.5s
🟢 choice controls place the exact order 7.8s
🟢 debounced search selects the target once results arrive 11.9s
🟢 tests/login-form.e2e.ts · 3 passed 49.0s
🟢 login form › rejects a malformed email 14.3s
🟢 login form › rejects an unknown account 14.4s
🟢 login form › signs in and logs out 20.3s
🟢 tests/smoke.e2e.ts · 1 passed 7.7s
🟢 home lists the scenarios and opens one 7.7s

Tested by e2e 0.23.0 · 7m 24s · ios-simulator · run artifacts

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

🟢 e2e android: 57 passed, 1 skipped

All 58 tests in 7 files
Test Time
⏭️ tests/controls.e2e.ts · 24 passed, 1 skipped 2m 32s
🟢 control inventory › a label query resolves a labeled text field 19.5s
🟢 control inventory › a labeled field answers name, display value, value reads, fill, and clear 10.7s
🟢 control inventory › a placeholder query and attribute reads find the field 4.9s
🟢 control inventory › a secure field takes a fill and denies value reads 5.3s
🟢 control inventory › press sends a character and Enter through the soft keyboard 7.3s
🟢 control inventory › a field autofocuses on mount and focus() moves the focus 7.1s
🟢 control inventory › toBeFocused follows the focus 7.9s
🟢 control inventory › a switch checks, unchecks, and reports its state 7.8s
🟢 control inventory › checkbox and radio roles answer getByRole, and a checkbox toggles by tap 6.5s
🟢 control inventory › checkbox and radio roles check, uncheck, and report their state 10.1s
🟢 control inventory › a tab role answers getByRole 3.7s
🟢 control inventory › a radio group reports the checked option 7.6s
🟢 control inventory › buttons report disabled, enabled, and a state that arrives later 6.5s
🟢 control inventory › a display: none element is absent rather than hidden, its visible twin attached 6.5s
🟢 control inventory › a header answers its accessible name 3.4s
🟢 control inventory › a tab row answers count, all, texts, filters, positions, and switching 5.1s
🟢 control inventory › a list answers counts, list-form text, reads, and boxes in order 5.2s
⏭️ control inventory › a row contains its texts (skipped: React Native flattens a plain View out of the accessibility tree on both platforms: XCTest and the Android helper report a View with a testID as a leaf beside its children, so filter({ has }) and a query scoped to it match nothing; only Sc…)
🟢 control inventory › a long press lands as one 6.9s
🟢 control inventory › a double tap lands inside the 300 ms window 6.3s
🟢 control inventory › an ambiguous locator fails at once 4.5s
🟢 control inventory › screenshot, restart, and clearState reopen the app on its home list 6.8s
🟢 refusals › verbs a device never declares are refused before the engine 2ms
🟢 refusals › keys the soft keyboard cannot send are refused by the engine 1.6s
🟢 refusals › a missing locator fails as not found once its timeout passes 1.1s
🟢 tests/device-fixture.e2e.ts · 10 passed 1m 11s
🟢 device fixture › setOrientation rotates the window the app measures 4.6s
🟢 device fixture › home leaves the app, openApp brings it back where it was 3.8s
🟢 device fixture › foregroundApp sees the home screen after home() 3.5s
🟢 device fixture › closeApp then openApp relaunches on the home list 5.9s
🟢 device fixture › closeApp leaves the next commands on the same device 6.3s
🟢 device fixture › foregroundApp after closeApp reports the closed session as APP_NOT_OPEN 4.0s
🟢 device fixture › device.back pops the scenario 4.4s
🟢 device fixture › unstable_raw reaches the test session through the raw driver 3.8s
🟢 device fixture › setNetwork and setAirplaneMode change what the app sees 14.3s
🟢 device fixture › setLocation and clearLocation change what the app reads 20.1s
🟢 tests/device.e2e.ts · 5 passed 38.8s
🟢 permission prompt › allowing the system dialog enables the microphone 5.4s
🟢 permission prompt › a denied prompt recovers once the permission is granted outside 12.0s
🟢 sequential onboarding echoes the exact values 9.7s
🟢 onboarding rejects a malformed email before advancing 5.5s
🟢 dismissing the keyboard over choice controls leaves them as they were 6.2s
🟢 tests/flows-lists.e2e.ts · 7 passed 3m 7s
🟢 infinite scroll reaches the target item 27.9s
🟢 product catalog adds exactly two of the right variant 8.1s
🟢 gestures: long-press, then swipe left 7.7s
🟢 gestures: double-tap completes the flow 8.9s
🟢 sticky chrome: accept below the fold, then continue 10.3s
🟢 async states: load, pull to refresh, claim through the toast 11.3s
🟢 huge virtualized list reaches row 512 1m 53s
🟢 tests/flows.e2e.ts · 7 passed 48.6s
🟢 text inputs unlock the submit button 6.1s
🟢 filled text inputs report their values 5.6s
🟢 modal flow confirms through the native alert 8.8s
🟢 bottom tabs act inside the last tab 6.3s
🟢 error recovery retries, then confirms the delete 8.1s
🟢 choice controls place the exact order 5.5s
🟢 debounced search selects the target once results arrive 8.2s
🟢 tests/login-form.e2e.ts · 3 passed 26.1s
🟢 login form › rejects a malformed email 7.3s
🟢 login form › rejects an unknown account 6.8s
🟢 login form › signs in and logs out 12.0s
🟢 tests/smoke.e2e.ts · 1 passed 5.2s
🟢 home lists the scenarios and opens one 5.2s

Tested by e2e 0.23.0 · 8m 50s · android-emulator · run artifacts

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 5 files (changes from recent commits).

Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

View guided diff | Turn on auto-fix | Re-trigger cubic

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/acp/tests/mcp.test.ts">

<violation number="1" location="packages/acp/tests/mcp.test.ts:84">
P3: The test name says the stream error is retained "without sending its text", but nothing checks that. `rejects.toThrow()` passes for any error, so assert that the client-side error does not contain the secret.</violation>
</file>

Comment thread packages/acp/tests/mcp.test.ts Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

View guided diff | Turn on auto-fix | Re-trigger cubic

@okwasniewski

Copy link
Copy Markdown
Member Author

[gpt-6.1-sol] responding on behalf of okwasniewski

Ready for human review at 00a7009; all checks passed and review threads are resolved. Remaining security follow-ups are listed in the PR description: the web redirect-header reports and three test-fixture scanning findings are outside this change, and no alerts were dismissed. The iOS clipboard test passed on retry after one empty read; the clipboard implementation is unchanged by this PR.

@okwasniewski
okwasniewski merged commit be460ec into main Nov 12, 2026
32 checks passed
@okwasniewski
okwasniewski deleted the t3/fix-dependabot-security-alerts branch November 12, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready for Human Review size:L Up to 499 changed lines, not counting tests, fixtures, translated docs, or the lockfile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant