Repository navigation
fix(security): redact tool outputs and patch vulnerable dependencies - #1715
Conversation
🟢 e2e web: 91 passedAll 91 tests in 41 files
Tested by e2e 0.23.0 · 1m 4s · web · run artifacts |
🟢 e2e web agent: 33 passed35 agent steps · 26 replayed from cache · 21 model calls · 89.4k tokens (93% cached) · $0.0039 All 33 tests in 5 files
Tested by e2e 0.23.0 · 1m 36s · web · run artifacts |
There was a problem hiding this comment.
All reported issues were addressed across 26 files
Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.
View guided diff | Turn on auto-fix | Re-trigger cubic
🟢 e2e ios agent: 21 passed, 1 skipped25 agent steps · 12 replayed from cache · 56 model calls · 362.2k tokens (83% cached) · $0.0240 All 22 tests in 1 file
Tested by e2e 0.23.0 · 8m 30s · ios-simulator · run artifacts |
There was a problem hiding this comment.
0 issues found across 8 files (changes from recent commits).
Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.
Requires human review: Auto-approval blocked by 2 unresolved issues from previous reviews.
View guided diff | Turn on auto-fix | Re-trigger cubic
🟢 e2e android agent: 20 passed24 agent steps · 15 replayed from cache · 35 model calls · 187.0k tokens (88% cached) · $0.0102 All 20 tests in 1 file
Tested by e2e 0.23.0 · 5m 46s · android-emulator · run artifacts |
🟢 e2e ios: 1 flaky, 54 passed, 1 skipped
|
| Test | Time | |
|---|---|---|
| tests/device-fixture.e2e.ts · 1 flaky, 10 passed | 1m 35s | |
| 🟢 | device fixture › setAppearance flips the color scheme the app reads | 13.8s |
| 🟢 | device fixture › setOrientation rotates the window the app measures | 12.3s |
| device fixture › the clipboard reads back what was written (1 failed attempt first) | 7.4s | |
| 🟢 | device fixture › home leaves the app, openApp brings it back where it was | 6.2s |
| 🟢 | device fixture › closeApp then openApp relaunches on the home list | 8.3s |
| 🟢 | device fixture › closeApp leaves the next commands on the same device | 11.6s |
| 🟢 | device fixture › foregroundApp after closeApp reports the closed session as APP_NOT_OPEN | 5.3s |
| 🟢 | device fixture › device.back pops the scenario | 5.5s |
| 🟢 | device fixture › unstable_raw reaches the test session through the raw driver | 4.5s |
| 🟢 | device fixture › setLocation and clearLocation change what the app reads | 10.0s |
| 🟢 | device fixture › enrollBiometrics and setBiometrics answer a biometric prompt | 9.7s |
| ⏭️ | tests/controls.e2e.ts · 23 passed, 1 skipped | 3m 4s |
| 🟢 | control inventory › a label query resolves a labeled text field | 10.4s |
| 🟢 | control inventory › a labeled field answers name, display value, value reads, fill, and clear | 18.9s |
| 🟢 | control inventory › a placeholder query and attribute reads find the field | 5.9s |
| 🟢 | control inventory › a secure field takes a fill and denies value reads | 10.0s |
| 🟢 | control inventory › press sends a character and Enter through the soft keyboard | 10.3s |
| 🟢 | control inventory › a field autofocuses on mount and focus() moves the focus | 10.2s |
| 🟢 | control inventory › toBeFocused follows the focus | 9.4s |
| 🟢 | control inventory › a switch checks, unchecks, and reports its state | 9.5s |
| 🟢 | control inventory › checkbox and radio roles answer getByRole, and a checkbox toggles by tap | 7.8s |
| 🟢 | control inventory › checkbox and radio roles check, uncheck, and report their state | 12.8s |
| 🟢 | control inventory › a radio group reports the checked option | 9.0s |
| 🟢 | control inventory › buttons report disabled, enabled, and a state that arrives later | 8.0s |
| 🟢 | control inventory › a display: none element is absent rather than hidden, its visible twin attached | 7.4s |
| 🟢 | control inventory › a header answers its accessible name | 4.3s |
| 🟢 | control inventory › a tab row answers count, all, texts, filters, positions, and switching | 6.1s |
| 🟢 | control inventory › a list answers counts, list-form text, reads, and boxes in order | 6.9s |
| ⏭️ | control inventory › a row contains its texts (skipped: React Native flattens a plain View out of the accessibility tree on both platforms: XCTest and the Android helper report a View with a testID as a leaf beside its children, so filter({ has }) and a query scoped to it match nothing; only Sc…) | |
| 🟢 | control inventory › a long press lands as one | 8.5s |
| 🟢 | control inventory › pointer verbs land at the point asked for | 9.4s |
| 🟢 | control inventory › an ambiguous locator fails at once | 6.0s |
| 🟢 | control inventory › screenshot, restart, and clearState reopen the app on its home list | 12.1s |
| 🟢 | refusals › verbs a device never declares are refused before the engine | 2ms |
| 🟢 | refusals › keys the soft keyboard cannot send are refused by the engine | 405ms |
| 🟢 | refusals › a missing locator fails as not found once its timeout passes | 1.1s |
| 🟢 | tests/device.e2e.ts · 3 passed | 1m 8s |
| 🟢 | sequential onboarding echoes the exact values | 41.4s |
| 🟢 | onboarding rejects a malformed email before advancing | 14.3s |
| 🟢 | dismissing the keyboard over choice controls leaves them as they were | 12.3s |
| 🟢 | tests/flows-lists.e2e.ts · 7 passed | 4m 27s |
| 🟢 | infinite scroll reaches the target item | 36.4s |
| 🟢 | product catalog adds exactly two of the right variant | 11.4s |
| 🟢 | gestures: long-press, then swipe left | 9.1s |
| 🟢 | sticky chrome: accept below the fold, then continue | 13.0s |
| 🟢 | async states: load, pull to refresh, claim through the toast | 12.1s |
| 🟢 | huge virtualized list reaches row 512 | 2m 51s |
| 🟢 | web view coupon form applies the code shown on the page | 13.3s |
| 🟢 | tests/flows.e2e.ts · 7 passed | 1m 11s |
| 🟢 | text inputs unlock the submit button | 13.3s |
| 🟢 | filled text inputs report their values | 10.3s |
| 🟢 | modal flow confirms through the native alert | 10.6s |
| 🟢 | bottom tabs act inside the last tab | 7.9s |
| 🟢 | error recovery retries, then confirms the delete | 9.5s |
| 🟢 | choice controls place the exact order | 7.8s |
| 🟢 | debounced search selects the target once results arrive | 11.9s |
| 🟢 | tests/login-form.e2e.ts · 3 passed | 49.0s |
| 🟢 | login form › rejects a malformed email | 14.3s |
| 🟢 | login form › rejects an unknown account | 14.4s |
| 🟢 | login form › signs in and logs out | 20.3s |
| 🟢 | tests/smoke.e2e.ts · 1 passed | 7.7s |
| 🟢 | home lists the scenarios and opens one | 7.7s |
Tested by e2e 0.23.0 · 7m 24s · ios-simulator · run artifacts
🟢 e2e android: 57 passed, 1 skippedAll 58 tests in 7 files
Tested by e2e 0.23.0 · 8m 50s · android-emulator · run artifacts |
There was a problem hiding this comment.
1 issue found across 5 files (changes from recent commits).
Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.
View guided diff | Turn on auto-fix | Re-trigger cubic
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/acp/tests/mcp.test.ts">
<violation number="1" location="packages/acp/tests/mcp.test.ts:84">
P3: The test name says the stream error is retained "without sending its text", but nothing checks that. `rejects.toThrow()` passes for any error, so assert that the client-side error does not contain the secret.</violation>
</file>
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
[gpt-6.1-sol] responding on behalf of okwasniewski Ready for human review at 00a7009; all checks passed and review threads are resolved. Remaining security follow-ups are listed in the PR description: the web redirect-header reports and three test-fixture scanning findings are outside this change, and no alerts were dismissed. The iOS clipboard test passed on retry after one empty read; the clipboard implementation is unchanged by this PR. |
What and why
fast-uri,@hono/node-server,glob, andminimatch.toModelOutputtext, and tool/engine errors before model input. Redact strings before truncation, and apply the live secret ledger to AI trace names, scope metadata, input, and output.Issue
Verified
Ran it locally: yes
mainand this branch.pnpm auditreports seven advisories--ai-trace. The fake provider rejects raw sentinel values. unbox-ai found the redacted marker in the trace and no raw sentinel matches.pnpm check; 55 focused core tests cover the final review changes. The preceding full core run passed 4,584 tests with 11 skipped. GitHub, ACP, BrowserStack, and TestMu suites also passed. Public declaration comparison: all 25 files unchanged.Checklist