Repository navigation
fix(claude): a review that posts nothing cannot be told from one that never ran - #234
Merged
Merged
Conversation
… never ran Live verification of the on-demand path after #233 merged: the job now completes (its checkout was broken until `f44ce3f`'s successor), the prompt carried `REPOSITORY`, `BASE_SHA` and `HEAD_SHA`, the model ran 17 turns for $0.328 — and it posted nothing at all: no summary, no inline comment, no review. The pull request had already been merged, which is exactly when a reader most needs telling what was reviewed. The skill now requires the summary unconditionally: say what you read, and that it is no longer actionable. That closes the last silent path in a procedure whose whole purpose is that a review cannot be mistaken for silence. `SKILL.md` was consolidated again to stay under its 20,000-byte ceiling (19,992): the same requirements, restated more tightly where two sentences said one thing. Refs #73
Code reviewBase: What the change doesAdds an unconditional closing rule to FindingsNo blocking findings. Instruction change reviewed as the change (base
Verified
Not verified
Earlier findingsNone: first review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #73
Follow-up to #233, from live evidence rather than inspection.
What happened
After #233 merged, I triggered the on-demand reviewer on it (
@claude review) to verify the path end to end — that path had been broken since it was written (git initleaves no remote, sogit fetch originfailed with exit 128; #233 fixed it to useactions/checkout, and its first live run at 10:42Z then succeeded: 17 turns, $0.328).It posted nothing: no summary comment, no inline comment, no review object. The pull request had already been merged. A run that reads a pull request and posts nothing cannot be distinguished from a run that never happened — the exact failure mode this integration exists to remove, in the state where a reader most needs telling.
Change
SKILL.md§7: always post the summary, whatever the state — say what you read and that it is no longer actionable, rather than leaving the reader to guess.Consolidated elsewhere in the same file to stay under the 20,000-byte ceiling (now 19,992): same requirements, tighter wording. No review requirement was removed.
Verification
check_evidence(97 refs, 0 unresolved) clean.test_the_review_always_posts_a_summary_whatever_the_pull_request_state.mainplus another on-demand run. The rule is instruction-level; its enforcement is the model's.