Skip to content

Conversation

@Lannakin
Copy link
Contributor

@Lannakin Lannakin commented Jan 5, 2026

I've done my best to follow the guide for contributing and:

Edited makeboards.py, although I am not sure if I understood what these parameters should be:

    elif name == "waveshare_rp2350_plus_w":
        BuildFlashMenu(name, chip, 4*1024*1024, [*smallfs, 1024*1024, 2*1024*1024, 3*1024*1024])
        BuildFlashMenu(name, chip, 16*1024*1024, [0, 15*1024*1024, 14*1024*1024, 12*1024*1024, 

(I do not know if the first BuildFlashMenu is correct to be included)
I also was unsure of what parameters 6, 7, and 10 should be, as the number I got for the device ID via udevadm attributes walk is quite different from the others' IDs (but the manufacturer code matched so).

MakeBoard("waveshare_rp2350_plus_w", "rp2350", "Waveshare", "RP2350 Plus W", "0x2e8a", "0x0009", 500, "WAVESHARE_RP2350_PLUS_W", 16, 0, "none", ["PICO_CYW43_SUPPORTED=1", "CYW43_PIN_WL_DYNAMIC=1"])

I guess the 7th parameter is power in mA? The schematic says the LDO is ME6217C33M5G, and the datasheet for that says it can output 800mA (this LDO is also used on the Waveshare RP2350B-Eth and RP2350B-Tiny), so I guess I'll update that and rerun the script.

I also added digital.cpp, pins_arduino.h, and init.cpp. The comments at the top of digital.cpp and pins_arduino.h include the datasheets I used as references.

i don't know how to test this without using the additional board manager
URLs in the arduino-cli.yaml file
updated makeboards.py, generated package_pico_index.template.json,
json/waveshare_rp2350_plus_w.json, and boards.txt.

had multiple cats on desk, but i don't think they made any rogue edits
@Lannakin
Copy link
Contributor Author

Lannakin commented Jan 5, 2026

Note: updated the pwr parameter in makeboards.py and reran the script.

…lus W"

changed: /variants/waveshare_rp2350_plus_w/, /tools/makeboards.py, and
reran makeboards.py
Copy link
Owner

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick glance at this looks good. Have you tried a few things on your board w/it yet? Thx!

Lannakin and others added 2 commits January 5, 2026 21:48
…USB pwr to 500mA, reran makeboards.py

tested with a sketch with a lot of I2C stuff and it works
@earlephilhower earlephilhower merged commit 04bc8e4 into earlephilhower:master Jan 6, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants