Skip to content

Allow for granule search for collection without SpatialExtent in UMM-G#1309

Merged
betolink merged 5 commits into
earthaccess-dev:mainfrom
lsterzinger:fix-spatial-for-gnssro-data
Apr 29, 2026
Merged

Allow for granule search for collection without SpatialExtent in UMM-G#1309
betolink merged 5 commits into
earthaccess-dev:mainfrom
lsterzinger:fix-spatial-for-gnssro-data

Conversation

@lsterzinger

@lsterzinger lsterzinger commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Description

This PR resolves #1305 where searching for granules in some of our collections that do not contain spatial information in the UMM-G record. The assumption that SpatialExtent is populated only seems to exist in the granule string representation, and my tests searching for data in my collection ( gnssro_cosmic1_jpl_l1b_2.0) were successful after this change.

The same assumption is made about TemporalExtent, but I'm guessing missing this is a less-common situation. I'm happy to adjust to check for both if desired.

If this requires a new test to be added, I'm happy to add that as well if I can be pointed in the right direction.


"Ready for review" checklist

  • Place this Pull Request (PR) in draft until it is ready for review (see below)
  • Please review our Pull Request Guide
  • Mark "ready for review" after following instructions in the guide

Merge checklist

  • PR title is descriptive
  • PR body contains links to related and resolved issues (e.g. closes #1)
  • If needed, CHANGELOG.md updated
  • If needed, docs and/or README.md updated
  • If needed, unit tests added (unsure how? see below!)
  • All checks passing (tip: comment pre-commit.ci autofix if pre-commit is failing)
  • At least one approval

Need help? We welcome contributions at every experience level. You don't have to
write tests alone — open your PR and ask for help. It's also fine to let GitHub run tests
for you, via Continuous Integration (CI),
instead of running them locally. If anything fails and you're not sure why, just
mention @earthaccess-dev/maintainers in a comment and we'll work with you!


📚 Documentation preview 📚: https://earthaccess--1309.org.readthedocs.build/en/1309/

@github-actions

github-actions Bot commented Apr 21, 2026

Copy link
Copy Markdown

Binder 👈 Launch a binder notebook on this branch for commit 798be4e

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit 95810fa

Binder 👈 Launch a binder notebook on this branch for commit f008d36

Binder 👈 Launch a binder notebook on this branch for commit 7e1923f

@lsterzinger lsterzinger changed the title Fix spatial for gnssro data Allow for granule search for collection without SpatialExtent in UMM-G Apr 21, 2026
@lsterzinger lsterzinger marked this pull request as ready for review April 21, 2026 16:20
betolink
betolink previously approved these changes Apr 22, 2026

@betolink betolink left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @lsterzinger since this is a simple change, you can optionally add a test, if you have time it would just creating a mocked umm record with and without spatial extent.

@betolink

Copy link
Copy Markdown
Member

@lsterzinger should we merge ?

@lsterzinger

Copy link
Copy Markdown
Contributor Author

If you don't think the test is needed I'm happy with a merge. I would be open to write a test but I wouldn't be able to get to work on it for at least a week. I can always submit another PR for it if that's alright with you

@betolink betolink self-requested a review April 29, 2026 18:34
@betolink betolink merged commit 46eb5ff into earthaccess-dev:main Apr 29, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Cannot search for granules within a collection with no spatial metadata

2 participants