Allow for granule search for collection without SpatialExtent in UMM-G#1309
Conversation
|
I will automatically update this comment whenever this PR is modified
|
There was a problem hiding this comment.
Thanks for the PR @lsterzinger since this is a simple change, you can optionally add a test, if you have time it would just creating a mocked umm record with and without spatial extent.
|
@lsterzinger should we merge ? |
|
If you don't think the test is needed I'm happy with a merge. I would be open to write a test but I wouldn't be able to get to work on it for at least a week. I can always submit another PR for it if that's alright with you |
Description
This PR resolves #1305 where searching for granules in some of our collections that do not contain spatial information in the UMM-G record. The assumption that SpatialExtent is populated only seems to exist in the granule string representation, and my tests searching for data in my collection (
gnssro_cosmic1_jpl_l1b_2.0) were successful after this change.The same assumption is made about TemporalExtent, but I'm guessing missing this is a less-common situation. I'm happy to adjust to check for both if desired.
If this requires a new test to be added, I'm happy to add that as well if I can be pointed in the right direction.
"Ready for review" checklist
Merge checklist
closes #1)CHANGELOG.mdupdatedREADME.mdupdatedpre-commit.ci autofixif pre-commit is failing)📚 Documentation preview 📚: https://earthaccess--1309.org.readthedocs.build/en/1309/