02-time-series-exercise

[nquarder]

Issue 1

Challenge 1: Explore Your Data & Metadata
Before you begin working with files using python, it can be helpful to look at the structure of the file itself. In some cases, text files metadata at the top of the file that tell you more about the data within the file itself.

• ...text files HAVE metadata at the top...

• I wonder if you might consider adding another line of instructions reminding students how to access that file and the metadata? Should they go back out to their main directory in the Hub and click through the folders to find the files or should they be doing that in python? I see they'll be opening the file using python in Challenge 2, so I'm wondering how we think they'll be opening the file and metadata in Challenge 1?

Issue 2

Challenge 2: Open and Plot a CSV File with Time Series Data
Once you have created your plot, answer the following questions.
What is the max value for stream charge in the data? One what date did that value occur?
Consider the entire dataset. Do you see any patterns of stream discharge values in the data?

• Where do we want students to submit their answers to these questions? Could there be another cell where their answers can go? Maybe include another cell where their answers could be added as a comment?

• In the cell where students build the figure you might add a comment at the top: # Build your plot here or something like that

Issue 3

Challenge 3: Subset the Data
The 2013 Colorad Flood occurred in 2013.

• Should be Colorado Flood

Subset the data to including only discharge data from August 1st, 2013 through October 31, 2013

• Should read: Subset the data to include

Issue 4

Bonus Challenge: Get Data from Hydrofunctions
3.) Resample the data calculate the annual maximum stream discharge value for each year.

• Resample the data to calculate

Issue 5

Bonus Challenge 2b

• Is this supposed to be in there?

[nkorinek]

Issue 1

Challenge 1: Explore Your Data & Metadata
Before you begin working with files using python, it can be helpful to look at the structure of the file itself. In some cases, text files metadata at the top of the file that tell you more about the data within the file itself.

* ...text files **_HAVE_** metadata at the top...

* I wonder if you might consider adding another line of instructions reminding students how to access that file and the metadata? Should they go back out to their main directory in the Hub and click through the folders to find the files or should they be doing that in python? I see they'll be opening the file using python in Challenge 2, so I'm wondering how we think they'll be opening the file and metadata in Challenge 1?

Really good question. Ya we'll instruct them to go to the download folder on the hub and open up the file just by clicking on it. Jupyter can display text files so they should be good to go if they just follow the paths to the files and click on them. Also: I noticed that the instructions here were changed to just review the csv file, but you'll notice if you open that file there is no metadata in it. I modified the instructions to tell them to also open up the txt file in order to see the metadata stored at the top of that file.

[nkorinek]

Issue 2

Challenge 2: Open and Plot a CSV File with Time Series Data
Once you have created your plot, answer the following questions. What is the max value for stream charge in the data? One what date did that value occur? Consider the entire dataset. Do you see any patterns of stream discharge values in the data?

* Where do we want students to submit their answers to these questions? Could there be another cell where their answers can go? Maybe include another cell where their answers could be added as a comment?

* In the cell where students build the figure you might add a comment at the top: `# Build your plot here`  or something like that

I included another cell with the answers for this section that the students can use to fill out the answers, and I added the text at the top of that cell!

[nkorinek]

Issue 3

Challenge 3: Subset the Data
The 2013 Colorad Flood occurred in 2013.

* Should be Colorad**o** Flood

Subset the data to including only discharge data from August 1st, 2013 through October 31, 2013

* Should read: _Subset the data to **include**_

Nice catches

[nkorinek]

Issue 4

Bonus Challenge: Get Data from Hydrofunctions
3.) Resample the data calculate the annual maximum stream discharge value for each year.

* Resample the data **_to_** calculate

Got it!

[nkorinek]

Issue 5

Bonus Challenge 2b

* Is this supposed to be in there?

Um, not sure. I tried to edit it but when I clicked on it it went away....I replaced it with a space to answer the above bonus challenge.

[nkorinek]

@nquarder finished this review, thanks for the notes!

[nquarder]

1.2 Challenge 1: Explore Your Data & Metadata

Python should be capitalized in the opening sentence of this section

[nquarder]

1.3 Challenge 2: Open and Plot a CSV File with Time Series Data

At the bottom of this cell there is a note that reads:

Your final plot should look like the plot below.

However there is no plot below for students to compare with.

[nquarder]

1.4 Challenge 3: Subset the Data

At step 2 of these instructions there is an extra is between y-axis and contains in the 2nd sentence.

[nquarder]

1.7 Bonus Challenge: Get Data from Hydrofunctions

• Python should be capitalized in the 1st sentence of this section.
• In steps 1-4 at the bottom of this section there is an extra right parentheses ) at the end of step 1.