Skip to content

Flush stream response to make it stream #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xxx7xxxx merged 3 commits into from
Dec 31, 2024
Merged

Flush stream response to make it stream #1364

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
adf832a
update flush policy
suchen-sci Dec 25, 2024
be1f74b
update response real time flush
suchen-sci Dec 25, 2024
1c436ed
add comments
suchen-sci Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions pkg/object/httpserver/mux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ func (mi *muxInstance) sendResponse(ctx *context.Context, stdw http.ResponseWrit
stdw.WriteHeader(resp.StatusCode())

var writer io.Writer
if responseNeedFlush(resp) {
if responseIsRealTime(resp) {
writer = NewResponseFlushWriter(stdw)
} else {
writer = stdw
Expand Down Expand Up @@ -287,15 +287,25 @@ func NewResponseFlushWriter(w http.ResponseWriter) *ResponseFlushWriter {
}
}

func responseNeedFlush(resp *httpprot.Response) bool {
// responseIsRealTime returns whether the response needs to be flushed immediately.
// The response needs to be flushed immediately if the response has no content length (chunked),
// or the response is a Server-Sent Events response.
func responseIsRealTime(resp *httpprot.Response) bool {
// Based on https://en.wikipedia.org/wiki/Chunked_transfer_encoding
// If the Transfer-Encoding header field is present in a response and its value is "chunked",
// then the body of response is considered as a stream of chunks.
if len(resp.TransferEncoding) > 0 && resp.TransferEncoding[0] == "chunked" && resp.ContentLength <= 0 {
return true
}

resCTHeader := resp.Std().Header.Get("Content-Type")
resCT, _, err := mime.ParseMediaType(resCTHeader)

// For Server-Sent Events responses, flush immediately.
// The MIME type is defined in https://www.w3.org/TR/eventsource/#text-event-stream
if err == nil && resCT == "text/event-stream" {
return true
}

return false
}

Expand Down
Loading