Add EasyBlock for CMake #1936
Merged
Add EasyBlock for CMake #1936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handles all custom parameters that are currently passed to configure so CMake ECs can be simpler Handles non-loaded modules gracefully instead of passing -DZLIB_LIBRARY_RELEASE=$EBROOTZLIB/lib/libz.so which results in -DZLIB_LIBRARY_RELEASE=/lib/libz.so if e.g. filter-deps=zlib is used
Contributor
Author
This was referenced Jan 21, 2020
akesandgren
requested changes
Feb 13, 2020
Member
|
@Flamefire Please also open a PR for a CMake easyconfig that uses this, so we have something to test with (either update latest CMake easyconfig, or create a new one for latest CMake on top of |
Contributor
Author
akesandgren
approved these changes
Feb 14, 2020
Contributor
|
Going in, thanks @Flamefire! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles all custom parameters that are currently passed to configure so CMake ECs can be simpler
Handles non-loaded modules gracefully instead of passing -DZLIB_LIBRARY_RELEASE=$EBROOTZLIB/lib/libz.so which results in
-DZLIB_LIBRARY_RELEASE=/lib/libz.so if e.g. filter-deps=zlib is used
FollowUp: Use this in all CMake ECs