openblas: remove tests from build_step and raise error on failed tests

[lexming]

Update for openblas easyblock to detect and raise an error on failed tests. Currently OpenBLAS is running its tests in the build step and the installation proceed regardless of their result.

• build_step will run a custom make command that is equivalent to make all but without the tests
• test_step will run the tests and raise an exception if any test fails.

Additional issues to be solved:

• (already present in current easyblock) many compilation variables are redefined. Example

gcc -O2 -ftree-vectorize -march=native -fno-math-errno -O2 -DMAX_STACK_ALLOC=2048 -fopenmp -Wall -m64 -DF_INTERFACE_GFORT -fPIC - DSMP_SERVER -DUSE_OPENMP -DNO_WARMUP -DMAX_CPU_NUMBER=24 -DMAX_PARALLEL_NUMBER=1 -DVERSION="0.3.7" -march=skylake-avx512 -DASMNAME= -DASMFNAME=_ -DNAME=_ -DCNAME= -DCHAR_NAME="_" -DCHAR_CNAME="" -DNO_AFFINITY -I. *-O2 -DMAX_STACK_ALLOC=2048 -fopenmp -Wall -m64 -DF_INTERFACE_GFORT -fPIC -DSMP_SERVER -DUSE_OPENMP -DNO_WARMUP -DMAX_CPU_NUMBER=24 -DMAX_PARALLEL_NUMBER=1 -DVERSION="0.3.7" -march=skylake-avx512 -DASMNAME=cblas_isamax -DASMFNAME=cblas_isamax_ -DNAME=cblas_isamax_ -DCNAME=cblas_isamax -DCHAR_NAME="cblas_isamax_" -DCHAR_CNAME="cblas_isamax" -DNO_AFFINITY -I.. -I. -UDOUBLE -UCOMPLEX -DCBLAS -c -DUSE_ABS -UUSE_MIN imax.c -o cblas_isamax.o

• (introduced by this PR) Header file lapack.h is not installed

[akesandgren]

LGTM

[akesandgren]

FYI, lapack.h has never been installed, lapacke.h is the one that gets installed.

[martin-frbg]

The lapack.h thing is a recent change by Reference-LAPACK a.k.a netlib - in 3.9.0 the pure lapack definitions have been split out into their own header file for easier use with a future LAPACK++
The redefiniton of variables is (usually) an unwanted side effect of passing CFLAGS via the environment (OpenBLAS issue 818, I tried to fix it a few years ago but got nowhere with the current mess of makefiles that tend to include each other )

[lexming]

@martin-frbg Thank you very much for the feedback, it's been really helpful to better understand these issues.

[lexming]

@akesandgren @boegel all issues fixed, no longer a WIP

[akesandgren]

Tested on broadwell and skylake with easybuilders/easybuild-easyconfigs#9852
broadwell -> no problem
skyake -> caught the fatal errors

No duplication of variable settings.
lapack.h installed.

Perfect...

[akesandgren]

LGTM

[akesandgren]

Going in, thanks @lexming!