-
Notifications
You must be signed in to change notification settings - Fork 295
take into account user defined gallium_drivers and swr_arches in Mesa easyblock #2006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I haven't seen this one when I opened #2007 but it is worth comparing them. What #2007 does better:
I don't think |
@Flamefire you are right, this easyblock would have failed with a
I tested these changes on Mesa-20.0.2-GCCcore-9.3.0.eb with the configration options listed in the description of #2006 (comment), plus the following ones:
Regarding the use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From @boegel
doing stuff in the constructor can be important to ensure --module-only works as expected (since that skips configure_step, but doesn't skip sanity_check_step)
So this is better. Still some minor things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
re-reviewed, tested and approved, thanks @lexming and @Flamefire! |
Current mesa easyblock fails the sanity checks if user customizes
gallium-drivers
orswr-arches
inconfigopts
.This PR fixes that issue by
configopts
gallium-drivers
is only set by easyblock if missing fromconfigopts
(as before)swr-arches
is only set by easyblock if missing fromconfigopts
andswr
is present ingallium-drivers
swr-arches
and regardless of who definedswr-arches
Tested cases:
configopts += "-Dgallium-drivers=''"
configopts += "-Dgallium-drivers='swrast'"
swr-arches
added and sanity checks do not include any SWR libsconfigopts += "-Dgallium-drivers='swrast,swr'"
swr-arches
added depending on CPU arch and respective SWR libs checked in sanity checksconfigopts += "-Dgallium-drivers='swrast,swr' -Dswr-arches=avx2"
swr-arches
is not modified andlibswrAVX2.so
is added to sanity checks