Skip to content

Conversation

@mboisson
Copy link
Contributor

@mboisson mboisson commented May 21, 2020

No description provided.

@boegel boegel changed the title added option use_pip_requirement to allow providing a requirements fi… added option use_pip_requirement to allow providing a requirements file to the pip command, as a source May 24, 2020
@boegel boegel added this to the 4.x milestone May 24, 2020
@boegel
Copy link
Member

boegel commented May 24, 2020

@mboisson Do you have a specific example use case for this?

@mboisson
Copy link
Contributor Author

mboisson commented May 24, 2020 via email

@mboisson
Copy link
Contributor Author

In general, the exts_list framework is not flexible enough to really support multi-python for python bundles, because the dependency graph can vary for different versions of python (in particular between python 2.7 and 3.x, but also sometimes within 3.x for different x).

@mboisson
Copy link
Contributor Author

Any way to move this forward ?

@akesandgren
Copy link
Contributor

Doesn't --requirement take an argument? If so, where does that come from ?

@mboisson
Copy link
Contributor Author

Yes, the requirement file would be the source file in this case.

@akesandgren
Copy link
Contributor

Ok, then this should perhaps be noted in the help text for use_pip_requirement. I.e. that it takes the req-file from the sources argument.

@mboisson
Copy link
Contributor Author

Ok, then this should perhaps be noted in the help text for use_pip_requirement. I.e. that it takes the req-file from the sources argument.

done

Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Contributor

Going in, thanks @mboisson!

@akesandgren akesandgren merged commit 0c17329 into easybuilders:develop Aug 28, 2020
@mboisson mboisson deleted the use_pip_requirement branch September 1, 2020 13:37
@boegel boegel modified the milestones: 4.x, next release (4.3.0) Sep 2, 2020
@boegel boegel changed the title added option use_pip_requirement to allow providing a requirements file to the pip command, as a source added option use_pip_requirement to PythonPackage to allow providing a requirements file to the pip command, as a source Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants