-
Notifications
You must be signed in to change notification settings - Fork 306
added option use_pip_requirement to PythonPackage to allow providing a requirements file to the pip command, as a source #2064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added option use_pip_requirement to PythonPackage to allow providing a requirements file to the pip command, as a source #2064
Conversation
…le to the pip command, as a source
|
@mboisson Do you have a specific example use case for this? |
|
In our case, installing our bundle modules which we install from wheels we compile independently. It is much easier to specify varying python dependencies with multi python using a requirements file than using the exts_list (plus the exts_list does not take from our wheel house).
…
On May 24, 2020 at 4:26 AM, <Kenneth Hoste ***@***.***)> wrote:
@mboisson (https://github.com/mboisson) Do you have a specific example use case for this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (#2064 (comment)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/ABZKY2X77WHRLUAWEAXML7DRTDK2RANCNFSM4NG6YPJA).
|
|
In general, the |
|
Any way to move this forward ? |
|
Doesn't --requirement take an argument? If so, where does that come from ? |
|
Yes, the requirement file would be the source file in this case. |
|
Ok, then this should perhaps be noted in the help text for use_pip_requirement. I.e. that it takes the req-file from the sources argument. |
done |
akesandgren
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Going in, thanks @mboisson! |
No description provided.