Skip to content

patch ELPA's manual_cpp script to fix hardcoded /usr/bin/python #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lexming merged 1 commit into from
Jul 27, 2020
Merged

patch ELPA's manual_cpp script to fix hardcoded /usr/bin/python #2107

lexming merged 1 commit into from
Jul 27, 2020

Conversation

@boegel
Copy link
Member

@boegel boegel commented Jul 22, 2020

ELPA requires Python as a build dep, but one of the scripts hardcodes /usr/bin/python...

@boegel boegel added the bug fix label Jul 22, 2020
@boegel boegel added this to the next release (4.2.3?) milestone Jul 22, 2020
lexming
lexming approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Contributor

lexming commented Jul 27, 2020

Tests in easybuilders/easybuild-easyconfigs#11011 (comment)

@lexming
Copy link
Contributor

lexming commented Jul 27, 2020

Going in, thanks @boegel !

@lexming lexming merged commit ec0b66c into easybuilders:develop Jul 27, 2020
@boegel boegel deleted the elpa_patch branch August 1, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lexming lexming lexming approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @lexming