Skip to content

make flake8 code style checks pass in o/*.py through v/*.py + other *.py files in repo #2137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
boegel merged 29 commits into from
Aug 20, 2020
Merged

make flake8 code style checks pass in o/*.py through v/*.py + other *.py files in repo #2137

boegel merged 29 commits into from
Aug 20, 2020

Conversation

@wpoely86
Copy link
Member

@wpoely86 wpoely86 commented Aug 20, 2020

@wpoely86 wpoely86 requested a review from boegel August 20, 2020 11:01
@boegel boegel added this to the next release (4.3.0) milestone Aug 20, 2020
@boegel boegel changed the title make flake8 code style checks pass in w-o make flake8 code style checks pass in o/*.py through v/*.py + other *.py files in repo Aug 20, 2020
@easybuilders easybuilders deleted a comment from boegelbot Aug 20, 2020
boegel
boegel requested changes Aug 20, 2020
View reviewed changes
@wpoely86
fix remarks
01400a0
@wpoely86
Merge remote-tracking branch 'origin/develop' into flakes_uvt
6467ae1 
* origin/develop:
  Flake8 clean generic
  [Flake8] Clean folder d
  Fix remaining flake8 issues
  Run autopep8 -a for folder b,c
  Run autopep8 for folder b,c
  Fix missing comma
  Improve line split
  Fix remaining flake8 issues
  Run autopep8 -a for folder a
  Run autopep8 for folder a
@wpoely86
try to fix tests more elegant by suggestion of Flamefire
f589b8c
@wpoely86
use kwargs properly
f421b89
boegel
boegel previously approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@boegel boegel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

boegel
boegel approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 31e3607 into easybuilders:develop Aug 20, 2020
@wpoely86 wpoely86 deleted the flakes_uvt branch August 20, 2020 14:44
@boegel boegel mentioned this pull request Nov 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

code cleanup

Projects

None yet

Milestone

4.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@wpoely86 @boegel