enhance extension filter for Python packages to ignore user site dir when for checking Python package extensions #2224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
changed the title
Contributor
|
And this does not negatively affect users doing their own installations with EB I hope? |
Contributor
Author
|
No. It just aligns the check with the install (and pretty much any other) python command used here |
Contributor
|
Going in, thanks @Flamefire! |
This was referenced Dec 3, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
EXTS_FILTER_PYTHON_PACKAGESis used as the default for checking whether to skip installing an extension. Now it excludes the user site dir and hence does not wrongly skip installing a package when it is present in the user folder.