add support to Boost easyblock for providing extra C++ compiler flags #2226
Conversation
| 'boost_mpi': [False, "Build mpi boost module", CUSTOM], | ||
| 'boost_multi_thread': [False, "Build boost with multi-thread option", CUSTOM], | ||
| 'toolset': [None, "Toolset to use for Boost configuration ('--with-toolset for bootstrap.sh')", CUSTOM], | ||
| 'extra_cxxflags': [None, "Extra C++ compiler flags to use", CUSTOM], |
There was a problem hiding this comment.
I wonder if an option like this would be better done as a toolchainopt in the framework?
Then EB just sets CXXFLAGS with the extra flags and it will be picked up with the existing logic in boost.py.
There was a problem hiding this comment.
Yeah, that's actually a good point...
Should probably also be an EasyBuild configuration option like --cxxflags (but perhaps as an override rather than to specify extra flags, so that would be a separate PR/feature).
There was a problem hiding this comment.
easybuilders/easybuild-framework#2193
is a start...
There was a problem hiding this comment.
It's actually exactly what's needed, thanks for reviving that PR!
|
Superseded by better solution in easybuilders/easybuild-framework#2193 |
2 participants
No description provided.