Skip to content

Conversation

@mboisson
Copy link
Contributor

This is needed for us because I need to pass CPATH for our installation of freetype in Gentoo.

@migueldiascosta
Copy link
Member

although using (pre)installopts here makes sense since in this easyblock building is done in the install_step, I wonder if from the user/easyconfig point of view it wouldn't make more sense to use (pre)buildopts...?

@migueldiascosta migueldiascosta added this to the 4.3.2 milestone Nov 16, 2020
@mboisson
Copy link
Contributor Author

Possibly. On one side, you would expect it to be in the build step. On the other side, if you put it in buildopts and you see it used in the install step when you look at the logs, it's just as puzzling.

@migueldiascosta
Copy link
Member

True, but the logs are already puzzling in that sense even without these opts, no? i.e., there should already be a log message about building being done in the install_step?

not a big deal though, so let me know if you prefer to leave it as it is

@mboisson
Copy link
Contributor Author

I would leave it as is.

Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Member

Going in, thanks @mboisson!

@migueldiascosta migueldiascosta merged commit a02b2e3 into easybuilders:develop Nov 20, 2020
@boegel boegel changed the title added support for preinstallopts and installopts to the ncl easyblock added support for preinstallopts and installopts to the NCL easyblock Nov 20, 2020
@boegel boegel changed the title added support for preinstallopts and installopts to the NCL easyblock take into account preinstallopts and installopts in custom easyblock for NCL Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants