Skip to content

Conversation

@Flamefire
Copy link
Contributor

Similar to #2238 but for SciPy

Supersedes #1744

Note: With SciPy-bundle-2019.03-foss-2019a.eb I get a failure due to a precision issue -.- Same with the 2019b

Those are very small failures, e.g. -0.00077271310043404 != -0.000772713100434114 (rdiff 9.569216326469691e-14) or "Arrays are not almost equal to 5 decimals" ... Max absolute difference: 1.5497208e-05

This is an AMD and Intel CPUs (x86)

@migueldiascosta
Copy link
Member

@Flamefire this should be marked as WIP, in terms of what to do regarding the small errors? (according to #2238 (comment))

@Flamefire Flamefire marked this pull request as draft November 19, 2020 07:43
@ocaisa
Copy link
Member

ocaisa commented Nov 19, 2020

If this passes in other more recent cases, then it is likely the tolerances were changed (or something improved) in later versions. It would be a shame to hold this back because of that, and it's effort to figure out patches to solve this. Given that these tests were effectively being ignored in the past, maintaining previous behaviour might just be disabling the scipy tests in the easyconfigs where these tests are failing?
Thoughts @boegel ?

@Flamefire
Copy link
Contributor Author

Flamefire commented Nov 19, 2020

Actually I couldn't get it to work with any scipy :(

Edit: Test report similar to the numpy tests coming up to check a few versions

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire

Overview of tested easyconfigs (in order)

Build succeeded for 2 out of 5 (5 easyconfigs in total)
taurusi6010.taurus.hrsk.tu-dresden.de - Linux RHEL 7.8, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/2e83105d7375d8411448f7bf4e221d40 for a full test report.

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles

Overview of tested easyconfigs (in order)

Build succeeded for 2 out of 26 (26 easyconfigs in total)
cnx3 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/3ce11425a72ba7cd7cda7187aac26c1c for a full test report.

@boegel
Copy link
Member

boegel commented Mar 1, 2023

superseded by #2862, so closing...

@boegel boegel closed this Mar 1, 2023
@Flamefire Flamefire deleted the scipy_tests branch March 1, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants