Skip to content

add foamMonitor to sanity checks of OpenFOAM #2256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
boegel merged 5 commits into from
Feb 19, 2021
Merged

add foamMonitor to sanity checks of OpenFOAM #2256

boegel merged 5 commits into from
Feb 19, 2021

Conversation

@lexming
Copy link
Contributor

@lexming lexming commented Nov 27, 2020 •
edited by boegel
Loading

@lexming lexming added this to the 4.3.2 (next release) milestone Nov 27, 2020
@lexming lexming mentioned this pull request Nov 27, 2020
Merged
@lexming
Copy link
Contributor Author

lexming commented Nov 28, 2020

@boegel
Copy link
Member

boegel commented Nov 28, 2020

@lexming There's a couple more things to check: how about older OpenFOAM versions, or variants (like OpenFOAM-Extend)?

Also, we can't merge this before adding the missing gnuplot to all OpenFOAM easyconfigs...

@boegel boegel mentioned this pull request Nov 29, 2020
Merged
boegel
boegel requested changes Nov 29, 2020
View reviewed changes
@boegel
Copy link
Member

boegel commented Nov 29, 2020

One additional complication: with OpenFOAM v2006, foamMonitor -help indeed complains when gnuplot is not found, but even if it is there, it always exits with exit code 1:

== 2020-11-29 12:58:18,658 build_log.py:169 ERROR EasyBuild crashed with an error (at easybuild/base/exceptions.py:124 in __init__): Sanity check failed: sanity check command source $FOAM_BASH && foamMonitor -help exited with code 1 (output:
Usage: foamMonitor [OPTION] <file>
options:
  -h | -help            prints the usage
  -i | -idle <time>     stops if <file> unchanging for <time> sec (default = 60)
  -l | -logscale        plots data (y-axis) on log scale, e.g. for residuals
  -r | -refresh <time>  refreshes display every <time> sec (default = 10)
  -y | -yrange <range>  sets data (y-axis) <range>, format "[0:1]"
  -g | -grid            draws grid lines on the plot

Monitor data with Gnuplot from time-value(s) graphs written by OpenFOAM
e.g. by functionObjects
- requires gnuplot, gnuplot_x11

Example:
  foamMonitor -l postProcessing/residuals/0/residuals.dat

So we should run foamMonitor -help, check whether it included "Usage: foamMonitor" (to check it includes the help output), but also that it doesn't include something like "Gnuplot not installed" or "which: no gnuplot in", at least for the versions where foamMonitor -help always exits with non-zero exit code...

@boegel boegel modified the milestones: 4.3.2 (next release), 4.4.0 Nov 29, 2020
@boegel
Copy link
Member

boegel commented Nov 29, 2020 •
edited
Loading

More complications: the oldest OpenFOAM versions don't include foamMonitor, for example with OpenFOAM-2.3.1-intel-2019b.eb:

sanity check command source $FOAM_BASH && foamMonitor -help exited with code 127
(output: /bin/bash: foamMonitor: command not found)

@lexming
Merge pull request #3 from boegel/foammonitor
aca950b 
only check for foamMonitor for OpenFOAM versions (not for OpenFOAM-Extend)
@lexming
Copy link
Contributor Author

lexming commented Nov 29, 2020 •
edited
Loading

That complicates things indeed. OpenFOAM v2.3 and older do not have foamMonitor. I'll add a version check as well.

@lexming
Copy link
Contributor Author

lexming commented Dec 1, 2020

Test report by @lexming

Overview of tested easyconfigs (in order)

  • SUCCESS OpenFOAM-8-foss-2020a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node374.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/5765d5e80caffb507f3581843e1e2785 for a full test report.

@lexming
Copy link
Contributor Author

lexming commented Dec 1, 2020

Test report by @lexming

Overview of tested easyconfigs (in order)

  • SUCCESS OpenFOAM-7-foss-2019b.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node357.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/ccca51d9d39b4ff796d4679648e2b209 for a full test report.

@lexming
Copy link
Contributor Author

lexming commented Dec 1, 2020

Test report by @lexming

Overview of tested easyconfigs (in order)

Build succeeded for 0 out of 1 (1 easyconfigs in total)
node357.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/ea52d3f0f7d91ebacf8a1bca40dd302d for a full test report.

@lexming
Copy link
Contributor Author

lexming commented Dec 1, 2020

Test report by @lexming

Overview of tested easyconfigs (in order)

  • SUCCESS OpenFOAM-2.2.x-intel-2019a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node357.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/6a4f04276cff158bb7e20d1e296c5d8c for a full test report.

@lexming
Copy link
Contributor Author

lexming commented Dec 1, 2020

Test report by @lexming

Overview of tested easyconfigs (in order)

  • SUCCESS OpenFOAM-2.3.1-intel-2019b.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node357.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/3564a713ad3d30ee0e4abb8fbb4a2b27 for a full test report.

@lexming
Copy link
Contributor Author

lexming commented Dec 1, 2020

Test report by @lexming

Overview of tested easyconfigs (in order)

Build succeeded for 0 out of 1 (1 easyconfigs in total)
node373.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/09234e4850748a056b5124e415f50ca0 for a full test report.

@lexming
Copy link
Contributor Author

lexming commented Dec 1, 2020

Test report by @lexming

Overview of tested easyconfigs (in order)

Build succeeded for 0 out of 1 (1 easyconfigs in total)
node364.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/c67e058eafca3a4a62a6ca63cd7b7b07 for a full test report.

@lexming
Copy link
Contributor Author

lexming commented Dec 1, 2020

Test report by @lexming

Overview of tested easyconfigs (in order)

Build succeeded for 0 out of 1 (1 easyconfigs in total)
node364.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/b08592084b580bf1aa33af0063a99c9d for a full test report.

@lexming
Copy link
Contributor Author

lexming commented Dec 1, 2020

Test report by @lexming

Overview of tested easyconfigs (in order)

Build succeeded for 3 out of 4 (1 easyconfigs in total)
node369.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/8749e641c5d961dd1b8fd37b1e3b527f for a full test report.

@lexming
Copy link
Contributor Author

lexming commented Dec 2, 2020

Test report by @lexming

Overview of tested easyconfigs (in order)

Build succeeded for 0 out of 1 (1 easyconfigs in total)
node381.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/376b518471236b43f8f7441eb0a22e95 for a full test report.

@lexming
Copy link
Contributor Author

lexming commented Dec 2, 2020

Test report by @lexming

Overview of tested easyconfigs (in order)

  • SUCCESS OpenFOAM-Extend-4.1-20200408-foss-2019b-Python-2.7.16.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node373.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/cd65251af4219be601a050782b52e53e for a full test report.

@lexming
Copy link
Contributor Author

lexming commented Dec 2, 2020

This PR now works as intended. All easyconfigs of OpenFOAM fail or pass the sanity checks as expected. Currently, the only ones passing are:

  • OpenFOAM <= v2.3, which do not have foamMonitor
  • OpenFOAM v7 and v8, which have been already updated with gnuplot
  • OpenFOAM-Extend, as it does not have foamMonitor

Next step, add the dependency on gnuplot to all easyconfigs of OpenFOAM that need it.

This was referenced Dec 2, 2020
Merged
Merged
@boegel boegel mentioned this pull request Feb 19, 2021
Merged
@branfosj branfosj mentioned this pull request Feb 19, 2021
Merged
@boegel
Copy link
Member

boegel commented Feb 19, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS OpenFOAM-v1812-foss-2018b.eb
  • SUCCESS OpenFOAM-v1906-foss-2019b.eb
  • SUCCESS OpenFOAM-v1912-foss-2019b.eb
  • SUCCESS OpenFOAM-v1912-intel-2019b.eb
  • SUCCESS OpenFOAM-v2006-foss-2020a.eb
  • SUCCESS OpenFOAM-v2012-foss-2020a.eb
  • SUCCESS OpenFOAM-2.3.1-intel-2019b.eb
  • SUCCESS OpenFOAM-2.4.0-intel-2019a.eb
  • SUCCESS OpenFOAM-Extend-4.0-intel-2019b-Python-2.7.16.eb
  • SUCCESS OpenFOAM-Extend-4.1-20191120-intel-2019b-Python-2.7.16.eb
  • SUCCESS OpenFOAM-Extend-4.1-20200408-foss-2019b-Python-2.7.16.eb
  • SUCCESS OpenFOAM-6-foss-2018b.eb
  • SUCCESS OpenFOAM-6-foss-2019b.eb
  • SUCCESS OpenFOAM-6-intel-2018a.eb
  • SUCCESS OpenFOAM-7-foss-2019b-20200508.eb
  • SUCCESS OpenFOAM-7-foss-2019b.eb
  • SUCCESS OpenFOAM-8-foss-2020a.eb

Build succeeded for 17 out of 17 (17 easyconfigs in total)
node3104.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/93a3b730671b1053859322bc614d44b9 for a full test report.

@boegel
Copy link
Member

boegel commented Feb 19, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS OpenFOAM-Extend-4.1-20200408-foss-2019b-Python-2.7.16.eb
  • SUCCESS OpenFOAM-2.2.x-intel-2019a.eb
  • SUCCESS OpenFOAM-2.4.0-intel-2019a.eb
  • SUCCESS OpenFOAM-3.0.1-intel-2018a.eb
  • SUCCESS OpenFOAM-5.0-20180108-foss-2018a.eb
  • SUCCESS OpenFOAM-5.0-20180108-intel-2017b.eb
  • SUCCESS OpenFOAM-5.0-20180108-intel-2018a.eb
  • SUCCESS OpenFOAM-5.0-foss-2017b.eb
  • SUCCESS OpenFOAM-5.0-intel-2017b.eb
  • SUCCESS OpenFOAM-6-foss-2018b.eb
  • SUCCESS OpenFOAM-6-foss-2019b.eb
  • SUCCESS OpenFOAM-6-intel-2018a.eb
  • SUCCESS OpenFOAM-7-foss-2019b-20200508.eb
  • SUCCESS OpenFOAM-7-foss-2019b.eb
  • SUCCESS OpenFOAM-8-foss-2020a.eb
  • SUCCESS OpenFOAM-v1606+-foss-2018b.eb
  • SUCCESS OpenFOAM-v1612+-foss-2018b.eb
  • SUCCESS OpenFOAM-v1712-foss-2017b.eb
  • SUCCESS OpenFOAM-v1712-intel-2017b.eb
  • SUCCESS OpenFOAM-v1806-foss-2018b.eb
  • SUCCESS OpenFOAM-v1812-foss-2018b.eb
  • SUCCESS OpenFOAM-v1906-foss-2019b.eb
  • SUCCESS OpenFOAM-v1912-foss-2019b.eb
  • SUCCESS OpenFOAM-v1912-intel-2019b.eb
  • SUCCESS OpenFOAM-v2006-foss-2020a.eb
  • SUCCESS OpenFOAM-v2012-foss-2020a.eb

Build succeeded for 26 out of 26 (26 easyconfigs in total)
node2666.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/4c27ac68f885d4129c800210554ad2ca for a full test report.

@boegel boegel merged commit db94f92 into easybuilders:develop Feb 19, 2021
@branfosj branfosj mentioned this pull request Feb 19, 2021
Closed
@lexming lexming deleted the foammonitor branch February 19, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.3.3

Development

Successfully merging this pull request may close these issues.

2 participants

@lexming @boegel