Update optional feature support of TensorFlow #2314
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr
)We used
TF_NEED_*
env variables to enable/disable features but those became out of sync with TF moving to--config
options. This adds a check for all setTF_*
variables that they are (still) relevant, i.e. contained inconfigure.py
and prints a warning (@boegel IMOprint_warning
makes more sense here as a failure likely results in misconfiguration of TF, but you were more sparing with the before, so what shall it be?)I also checked all variables through
git bisect
to find when they were introduced or removed and adapted the code to only use the valid ones.There may be functional changes because
--config=no*
options were missing before but I'd consider those as a bugfix, not a change becauseTF_NEED_*=0
was used for those.