Skip to content

enhance PythonPackage easyblock to catch faulty version (0.0.0) for installed Python packages #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bartoldeman merged 3 commits into from
Mar 26, 2021
Merged

enhance PythonPackage easyblock to catch faulty version (0.0.0) for installed Python packages #2367

bartoldeman merged 3 commits into from
Mar 26, 2021

Conversation

@Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Mar 24, 2021 •
edited
Loading

This catches the case where a Python package with no version is installed, e.g. by using the source package which needs to get the version attached (often done by tox which uses the tag from the VCS)

Follow-up to easybuilders/easybuild-easyconfigs#12455

@Flamefire Flamefire mentioned this pull request Mar 24, 2021
Merged
@Flamefire
Copy link
Contributor Author

Flamefire commented Mar 24, 2021

Test report by @Flamefire

Overview of tested easyconfigs (in order)

  • SUCCESS pkgconfig-1.5.1-GCCcore-8.2.0-python.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
taurusa9 - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2603 v4 @ 1.70GHz (broadwell), Python 2.7.5
See https://gist.github.com/0b929291a263cb792cd2386d136cb380 for a full test report.

bartoldeman
bartoldeman approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bartoldeman bartoldeman added this to the next release (4.3.4?) milestone Mar 26, 2021
@bartoldeman bartoldeman merged commit cad8b1f into easybuilders:develop Mar 26, 2021
@Flamefire Flamefire deleted the pythonpackageImprovements branch March 26, 2021 12:47
@boegel boegel changed the title Catch faulty Python package versions enhance PythonPackage easyblock to catch faulty version (0.0.0) for installed Python packages Mar 31, 2021
boegel added a commit to boegel/easybuild-easyconfigs that referenced this pull request Apr 4, 2021
@boegel
avoid 0.0.0 version for carputils 20200915 (cfr. easybuilders/easybui…
d63f224 
…ld-easyblocks#2367)
@boegel boegel mentioned this pull request Apr 5, 2021
Merged
@boegel boegel mentioned this pull request Oct 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bartoldeman bartoldeman bartoldeman approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.3.4

Development

Successfully merging this pull request may close these issues.

2 participants

@Flamefire @bartoldeman