Skip to content

enhance BWA easyblock: pass compiler flags + use filetools functions #2368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
verdurin merged 1 commit into from
Mar 26, 2021
Merged

enhance BWA easyblock: pass compiler flags + use filetools functions #2368

verdurin merged 1 commit into from
Mar 26, 2021

Conversation

@boegel
Copy link
Member

@boegel boegel commented Mar 24, 2021

(created using eb --new-pr)

@boegel boegel mentioned this pull request Mar 24, 2021
Merged
@boegel boegel added this to the next release (4.3.4?) milestone Mar 24, 2021
@boegel
Copy link
Member Author

boegel commented Mar 24, 2021

No BWA easyconfigs were hurt by these changes, test report for all existing BWA easyconfigs coming up...

@boegel
Copy link
Member Author

boegel commented Mar 24, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS BWA-0.7.17-GCC-8.2.0-2.31.1.eb
  • SUCCESS BWA-0.7.17-GCC-8.3.0.eb
  • SUCCESS BWA-0.7.17-GCC-9.3.0.eb
  • SUCCESS BWA-0.7.17-iccifort-2019.1.144-GCC-8.2.0-2.31.1.eb
  • SUCCESS BWA-0.7.17-iccifort-2019.5.281.eb

Build succeeded for 5 out of 5 (5 easyconfigs in total)
node3507.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/aabd1cf3526cbe146a33f24025577310 for a full test report.

@boegel
Copy link
Member Author

boegel commented Mar 24, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS BWA-0.7.12-foss-2016b.eb
  • SUCCESS BWA-0.7.13-foss-2016a.eb
  • SUCCESS BWA-0.7.13-intel-2016a.eb
  • SUCCESS BWA-0.7.15-GCCcore-5.4.0.eb
  • SUCCESS BWA-0.7.15-GCCcore-6.4.0.eb
  • SUCCESS BWA-0.7.15-foss-2016a.eb
  • SUCCESS BWA-0.7.15-foss-2016b.eb
  • SUCCESS BWA-0.7.15-intel-2016b.eb
  • SUCCESS BWA-0.7.15-intel-2017a.eb
  • SUCCESS BWA-0.7.16a-foss-2016b.eb
  • SUCCESS BWA-0.7.16a-intel-2017a.eb
  • SUCCESS BWA-0.7.17-GCC-8.2.0-2.31.1.eb
  • SUCCESS BWA-0.7.17-GCC-8.3.0.eb
  • SUCCESS BWA-0.7.17-GCC-9.3.0.eb
  • SUCCESS BWA-0.7.17-foss-2017b.eb
  • SUCCESS BWA-0.7.17-foss-2018a.eb
  • SUCCESS BWA-0.7.17-foss-2018b.eb
  • SUCCESS BWA-0.7.17-iccifort-2019.1.144-GCC-8.2.0-2.31.1.eb
  • SUCCESS BWA-0.7.17-iccifort-2019.5.281.eb
  • SUCCESS BWA-0.7.17-intel-2017b.eb
  • SUCCESS BWA-0.7.17-intel-2018a.eb
  • SUCCESS BWA-0.7.17-intel-2018b.eb

Build succeeded for 22 out of 22 (22 easyconfigs in total)
node2606.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/10e41aa00ca2b78f618d2ffa77a892cd for a full test report.

@boegel
Copy link
Member Author

boegel commented Mar 25, 2021

@verdurin easybuilders/easybuild-easyconfigs#12472 is merged already, but that requires the changes in this easyblock...

@verdurin verdurin merged commit ec46e85 into easybuilders:develop Mar 26, 2021
@boegel boegel deleted the 20210324194517_new_pr_draTZOligY branch March 26, 2021 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@verdurin verdurin verdurin approved these changes

Assignees

No one assigned

Labels

code cleanup enhancement

Projects

None yet

Milestone

4.3.4

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @verdurin