Skip to content

Make Tkinter easyblock work with --module-only #2416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
boegel merged 2 commits into from
May 12, 2021
Merged

Make Tkinter easyblock work with --module-only #2416

boegel merged 2 commits into from
May 12, 2021

Conversation

@ocaisa
Copy link
Member

@ocaisa ocaisa commented May 10, 2021 •
edited
Loading

Fixes #2401

@ocaisa ocaisa added bug fix EESSI Related to EESSI project labels May 10, 2021
@boegel boegel added this to the next release (4.3.5?) milestone May 12, 2021
@boegel
Copy link
Member

boegel commented May 12, 2021 •
edited
Loading

Test report by @boegel (using --module-only)

Overview of tested easyconfigs (in order)

  • SUCCESS Tkinter-2.7.16-GCCcore-8.3.0.eb
  • SUCCESS Tkinter-2.7.18-GCCcore-10.2.0.eb
  • SUCCESS Tkinter-2.7.18-GCCcore-9.3.0.eb
  • SUCCESS Tkinter-3.6.6-foss-2018b-Python-3.6.6.eb
  • SUCCESS Tkinter-3.7.4-GCCcore-8.3.0.eb
  • SUCCESS Tkinter-3.8.2-GCCcore-9.3.0.eb
  • SUCCESS Tkinter-3.8.6-GCCcore-10.2.0.eb

Build succeeded for 7 out of 7 (7 easyconfigs in total)
node2601.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/6eaf7baf3319b1d08f9833bc524cc5a6 for a full test report.

boegel
boegel approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented May 12, 2021 •
edited
Loading

Test report by @boegel (reinstall without --module-only)

Overview of tested easyconfigs (in order)

  • SUCCESS Tkinter-3.8.6-GCCcore-10.2.0.eb
  • SUCCESS Tkinter-2.7.18-GCCcore-10.2.0.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3506.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/3203174ea788276aaa3ac62b1ae0d0b6 for a full test report.

@boegel boegel merged commit 1376511 into easybuilders:develop May 12, 2021
@ocaisa ocaisa deleted the tkinter_module_only branch May 12, 2021 15:02
@ocaisa ocaisa mentioned this pull request Jun 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix EESSI Related to EESSI project

Projects

None yet

Milestone

4.4.0

Development

Successfully merging this pull request may close these issues.

Tkinter easyblock does not work with --module-only

2 participants

@ocaisa @boegel