-
Notifications
You must be signed in to change notification settings - Fork 307
Enhance BWA easyblock to copy includes and libraries #2417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance BWA easyblock to copy includes and libraries #2417
Conversation
ocaisa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to add some additional checks in the sanity_check_step for (some of?) the new includes and libraries.
|
Test report by @ocaisa Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (3 easyconfigs in total) |
Co-authored-by: ocaisa <[email protected]>
|
Test report by @ocaisa Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (3 easyconfigs in total) |
ocaisa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks @jfgrimm ! |
(created using
eb --new-pr)libbwa.a is already built by the Makefile, this just copies the library and header files into the installdir.