Skip to content

Conversation

@jfgrimm
Copy link
Member

@jfgrimm jfgrimm commented May 11, 2021

(created using eb --new-pr)
libbwa.a is already built by the Makefile, this just copies the library and header files into the installdir.

Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add some additional checks in the sanity_check_step for (some of?) the new includes and libraries.

@boegel boegel added this to the next release (4.3.5?) milestone May 12, 2021
@jfgrimm jfgrimm requested a review from ocaisa May 12, 2021 09:53
@ocaisa
Copy link
Member

ocaisa commented May 12, 2021

Test report by @ocaisa

Overview of tested easyconfigs (in order)

  • SUCCESS BWA-0.7.17-GCC-10.2.0.eb
  • SUCCESS BWA-0.7.17-GCC-9.3.0.eb
  • SUCCESS BWA-0.7.17-GCC-8.3.0.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
generoso - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz, Python 3.6.8
See https://gist.github.com/89807204122edebc1a1f46588c109578 for a full test report.

@ocaisa
Copy link
Member

ocaisa commented May 12, 2021

Test report by @ocaisa

Overview of tested easyconfigs (in order)

  • SUCCESS BWA-0.7.17-GCC-10.2.0.eb
  • SUCCESS BWA-0.7.17-GCC-9.3.0.eb
  • SUCCESS BWA-0.7.17-GCC-8.3.0.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
generoso - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz, Python 3.6.8
See https://gist.github.com/3f5fa7f146e48534e2675c8944454712 for a full test report.

Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocaisa
Copy link
Member

ocaisa commented May 12, 2021

Thanks @jfgrimm !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants