-
Notifications
You must be signed in to change notification settings - Fork 308
Honor --ignore-test-failure in PythonPackage #2516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 0 out of 1 (1 easyconfigs in total) |
|
@Flamefire w.r.t. the initial failures with tracebacks, it seems you got around that by splitting the PR, isolating the modified easyblocks. Off the top of my head, this may be related to the cleaning up after can you please open an issue with more information on this? |
|
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
|
just for completeness sake, this refers to the wrapper introduced in easybuilders/easybuild-framework#3732 |
migueldiascosta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Going in, thanks @Flamefire! |
As PythonPackage calls test_step directly the wrapping is missed. So call the wrapper instea