Skip to content

Conversation

@Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Jul 15, 2021

As PythonPackage calls test_step directly the wrapping is missed. So call the wrapper instea

@Flamefire Flamefire changed the title Honor --ignore-test-failure in PythonbPackage Honor --ignore-test-failure in PythonPackage Jul 15, 2021
@Flamefire
Copy link
Contributor Author

Test report by @Flamefire

Overview of tested easyconfigs (in order)

  • **FAIL (unhandled exception: must be type, not None)Traceback (most recent call last):
    File "/home/h3/s3248973/.local/EasyBuildDev/easybuild-framework/easybuild/main.py", line 118, in build_and_install_software
    (ec_res['success'], app_log, err) = build_and_install_one(ec, init_env)
    File "/home/s3248973/.local/EasyBuildDev/easybuild-framework/easybuild/framework/easyblock.py", line 3697, in build_and_install_one
    result = app.run_all_steps(run_test_cases=run_test_cases)
    File "/home/s3248973/.local/EasyBuildDev/easybuild-framework/easybuild/framework/easyblock.py", line 3585, in run_all_steps
    self.run_step(step_name, step_methods)
    File "/home/s3248973/.local/EasyBuildDev/easybuild-framework/easybuild/framework/easyblock.py", line 3438, in run_step
    step_method(self)()
    File "/home/s3248973/.local/EasyBuildDev/easybuild-easyblocks/easybuild/easyblocks/generic/pythonbundle.py", line 128, in extensions_step
    super(PythonBundle, self).extensions_step(*args, **kwargs)
    File "/home/s3248973/.local/EasyBuildDev/easybuild-framework/easybuild/framework/easyblock.py", line 2402, in extensions_step
    self.init_ext_instances()
    File "/home/s3248973/.local/EasyBuildDev/easybuild-framework/easybuild/framework/easyblock.py", line 2332, in init_ext_instances
    inst = cls(self, ext)
    File "/tmp/easybuild-tmp/included-easyblocks-iBqB1u/easybuild/easyblocks/tensorflow.py", line 239, in init
    super(EB_TensorFlow, self).init(*args, **kwargs)
    File "/tmp/easybuild-tmp/included-easyblocks-iBqB1u/easybuild/easyblocks/generic/pythonpackage.py", line 278, in init
    super(PythonPackage, self).init(*args, **kwargs)
    TypeError: must be type, not None
    ** TensorFlow-2.5.0-fosscuda-2019b-Python-3.7.4.eb

Build succeeded for 0 out of 1 (1 easyconfigs in total)
taurusa5 - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2603 v4 @ 1.70GHz (broadwell), Python 2.7.5
See https://gist.github.com/7cb9295fbae7ab03d2ec92e9ac64e343 for a full test report.

@migueldiascosta
Copy link
Member

@Flamefire w.r.t. the initial failures with tracebacks, it seems you got around that by splitting the PR, isolating the modified easyblocks. Off the top of my head, this may be related to the cleaning up after verify_imports, and possibly with the fact that the two modified easyblocks were related by inheritance, but I'm not sure

can you please open an issue with more information on this?

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire

Overview of tested easyconfigs (in order)

  • SUCCESS TensorFlow-2.5.0-fosscuda-2019b-Python-3.7.4.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
taurusa5 - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2603 v4 @ 1.70GHz (broadwell), Python 2.7.5
See https://gist.github.com/ea24d525c478a8d6326bb4655f7906b6 for a full test report.

@migueldiascosta
Copy link
Member

just for completeness sake, this refers to the wrapper introduced in easybuilders/easybuild-framework#3732

Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Member

Going in, thanks @Flamefire!

@migueldiascosta migueldiascosta merged commit 7a27d88 into easybuilders:develop Jul 26, 2021
@Flamefire Flamefire deleted the test_failure branch July 26, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants