enhance Geant4 easyblock: add support for optional build options #2659
Conversation
boegel
changed the title
| # map software requirements and corresponding configopts to custom options | ||
| custom_options_map = { | ||
| # option: ([dep_names], configopt) | ||
| 'enable_freetype': (['freetype'], "-DGEANT4_USE_FREETYPE=ON"), |
There was a problem hiding this comment.
We would normally do this the other way around.
I.e., if the easyconfig has freetype as a dependency, turn on GEANT4_USE_FREETYPE
That makes for less things to tinker with in the easyconfig.
The same of course goes for everything else with simple dep(s) -> enable-something
| self.cfg.update('configopts', cfg_opt) | ||
|
|
||
| # cannot enable both OpenInventor and OpenInventorQt | ||
| if self.cfg['enable_inventor'] and self.cfg['enable_inventorqt']: |
There was a problem hiding this comment.
So this would then become a check if both SoXt and SoQt are included as deps.
| 'install_data': [False, "Download and install Geant4 datasests", CUSTOM], | ||
| 'install_data_dir': [False, "Custom directory for Geant4 data files", CUSTOM], |
There was a problem hiding this comment.
There is already a Geant4-data easyconfig that Geant4 should depend on that handles the data.
I suggest using that instead.
That way there is a consistent version of data installed for each version of Geant4
There was a problem hiding this comment.
good point, I somehow missed that
|
@jfgrimm any updates on this? |
3 participants
(created using
eb --new-pr)