Skip to content

add support to NAMD easyblock to opt out of building with CUDA support even if CUDA is included as dependency #2666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ocaisa merged 2 commits into from
Feb 4, 2022
Merged

add support to NAMD easyblock to opt out of building with CUDA support even if CUDA is included as dependency #2666

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f1247d
To enable the enabling of CUDA as desired, instead of automatically.
damianam Jan 28, 2022
5119142
As suggested in https://github.com/easybuilders/easybuild-easyblocks/…
Feb 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion easybuild/easyblocks/n/namd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ def extra_options():
'charm_arch': [None, "Charm++ target architecture", MANDATORY],
'charm_extra_cxxflags': ['', "Extra C++ compiler options to use for building Charm++", CUSTOM],
'charm_opts': ['--with-production', "Charm++ build options", CUSTOM],
'cuda': [None, "Enable CUDA build if CUDA is among the dependencies", CUSTOM],
'namd_basearch': [None, "NAMD base target architecture (compiler family is appended)", CUSTOM],
'namd_cfg_opts': ['', "NAMD configure options", CUSTOM],
'runtest': [True, "Run NAMD test case after building", CUSTOM],
Expand Down Expand Up @@ -152,8 +153,12 @@ def configure_step(self):

# NAMD dependencies: CUDA, TCL, FFTW
cuda = get_software_root('CUDA')
if cuda:
if cuda and (self.cfg['cuda'] is None or self.cfg['cuda']):
self.cfg.update('namd_cfg_opts', "--with-cuda --cuda-prefix %s" % cuda)
elif not self.cfg['cuda']:
self.log.warning("CUDA is disabled")
elif not cuda and self.cfg['cuda']:
raise EasyBuildError("CUDA is not a dependency, but support for CUDA is enabled.")

tcl = get_software_root('Tcl')
if tcl:
Expand Down