Skip to content

Conversation

@lexming
Copy link
Contributor

@lexming lexming commented Feb 1, 2022

The gif tools in HDF5 are no longer built by default due to multiple CVEs.
See https://support.hdfgroup.org/ftp/HDF5/releases/hdf5-1.10/hdf5-1.10.8/src/hdf5-1.10.8-RELEASE.txt

Since the build of the affected tools can still be enabled by the user with --enable-hltools, I propose to not check either their presence or absence in the sanity checks.

@lexming
Copy link
Contributor Author

lexming commented Feb 2, 2022

Test report by @lexming

Overview of tested easyconfigs (in order)

Build succeeded for 9 out of 13 (13 easyconfigs in total)
node301.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/623394e0786d3f6eae21841e8a7b2e1f for a full test report.

@boegel
Copy link
Member

boegel commented Feb 2, 2022

@lexming What's up with the failing checksum in your test report?

@boegel boegel changed the title remove vulnerable binaries from sanity check of HDF5 remove vulnerable binaries from sanity check of HDF5, no longer installed by default with HDF5 1.10.8 Feb 2, 2022
@boegel boegel added update and removed bug fix labels Feb 2, 2022
@boegel boegel modified the milestones: 4.x, next release (4.5.3?) Feb 2, 2022
@lexming
Copy link
Contributor Author

lexming commented Feb 2, 2022

tar: Unexpected EOF in archive

@boegel the download was interrupted, re-fetched and re-testing

@lexming
Copy link
Contributor Author

lexming commented Feb 2, 2022

Test report by @lexming

Overview of tested easyconfigs (in order)

  • SUCCESS HDF5-1.10.5-gompi-2019a.eb
  • SUCCESS HDF5-1.10.5-gompi-2019b.eb
  • SUCCESS HDF5-1.10.5-gompic-2019a.eb
  • SUCCESS HDF5-1.10.5-gompic-2019b.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
node316.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/56a07e3427e0d8c9b1b54a2af10abac2 for a full test report.

Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocaisa ocaisa merged commit 55d1bfb into easybuilders:develop Feb 2, 2022
@lexming lexming deleted the hdf5 branch February 2, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants