Skip to content

Conversation

@boegel
Copy link
Member

@boegel boegel commented Mar 25, 2022

@boegel boegel added the bug fix label Mar 25, 2022
@boegel boegel added this to the next release (4.5.4?) milestone Mar 25, 2022
@boegel
Copy link
Member Author

boegel commented Mar 25, 2022

@akesandgren and/or @zao: Can you verify that this indeed fixes the log leaking issue that was reported in easybuilders/easybuild-framework#3533?

@akesandgren
Copy link
Contributor

Yep, problem fixed (and log file now ends with "Closing log for application name libpthread-stubs" which it didn't before).

Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Contributor

Going in, thanks @boegel!

@akesandgren akesandgren merged commit 1ecd289 into easybuilders:develop Mar 25, 2022
@boegel boegel deleted the bundle_close_log branch March 25, 2022 12:49
@boegel
Copy link
Member Author

boegel commented Mar 25, 2022

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS X11-20210802-GCCcore-11.2.0.eb
  • SUCCESS matplotlib-3.5.1-intel-2020b.eb
  • SUCCESS foss-2020b.eb
  • SUCCESS OpenSSL-1.0.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
node3510.doduo.os - Linux RHEL 8.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/a022c78b4ea09402a19a97a73f9e3750 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Log files in robot build leak into each other

2 participants