Skip to content

Conversation

@boegel
Copy link
Member

@boegel boegel commented May 30, 2022

post_install_step was redefined in #2721 by @mboisson to support installing Clang with Python bindings, but the default implementation of post_install_step in EasyBlock does a bunch of (potentially) useful things that we should keep doing...

See also https://github.com/easybuilders/easybuild-framework/blob/4c3b0522f6d2df50078a563f0161ba18b767851f/easybuild/framework/easyblock.py#L2861

@boegel boegel added the bug fix label May 30, 2022
@boegel boegel added this to the 4.5.5 milestone May 30, 2022
@boegel boegel requested a review from branfosj May 30, 2022 15:20
Copy link
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Member

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS Clang-13.0.1-GCCcore-11.2.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/444253ad3bdd91b97049b153f0cb30ac for a full test report.

@branfosj
Copy link
Member

Going in, thanks @boegel!

@branfosj branfosj merged commit 5812641 into easybuilders:develop May 30, 2022
@boegel boegel deleted the clang_post_install_step branch May 30, 2022 17:54
@boegel
Copy link
Member Author

boegel commented May 31, 2022

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Clang-9.0.1-GCCcore-9.3.0.eb
  • SUCCESS Clang-12.0.1-GCCcore-10.3.0.eb
  • SUCCESS Clang-13.0.1-GCCcore-11.2.0.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3141.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/5d06130aff5842f0f4eed31060aae0c3 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants