add support to ConfigureMake for tweaking (first part of) test command via 'test_cmd'

[boegel]

No description provided.

[Micket]

lgtm

[ocaisa]

Test report by @ocaisa

Overview of tested easyconfigs (in order)

• SUCCESS LZO-2.10-GCCcore-11.2.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
login1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz, Python 3.6.8
See https://gist.github.com/368871719e7f00fa3787aaa8b0291342 for a full test report.

[ocaisa]

@boegel Interestingly, if I use this (with test_cmd = 'echo' in the ec) it works just fine:

== testing...
  >> running command:
        [started at: 2022-05-31 09:46:40]
        [working dir: /home/ocaisa/.local/easybuild/build/LZO/2.10/GCCcore-11.2.0/lzo-2.10]
        [output logged in /tmp/eb-0ij5uqg8/easybuild-run_cmd-0_0up1wg.log]
        echo test
  >> command completed: exit 0, ran in < 1s

but if I do the same thing in extended dry run mode, it reports the default:

[test_step method]
  >> running command:
	[started at: 2022-05-31 09:48:56]
	[working dir: /tmp/eb-baidba6y/__ROOT__/home/ocaisa/.local/easybuild/build/LZO/2.10/GCCcore-11.2.0/LZO-2.10]
	[output logged in /tmp/eb-baidba6y/easybuild-run_cmd-xlokny0u.log]
	make test
  running command "make test"
  (in /home/ocaisa/.local/easybuild/build/LZO/2.10/GCCcore-11.2.0/LZO-2.10)

That's because the easyblock git patch is never actually applied, which I think would perhaps not be expected. I'll open an issue for that.

[boegel]

Test report by @boegel

Overview of tested easyconfigs (in order)

• SUCCESS VEP-105-GCC-11.2.0.eb
• SUCCESS BioPerl-1.7.8-GCCcore-10.3.0.eb
• SUCCESS zlib-1.2.11-GCCcore-9.3.0.eb
• SUCCESS wget-1.21.1-GCCcore-10.3.0.eb
• SUCCESS protobuf-2.5.0-GCCcore-10.2.0.eb
• SUCCESS OSU-Micro-Benchmarks-5.6.3-iimpi-2020b.eb
• SUCCESS MPFR-4.1.0-GCCcore-10.3.0.eb
• SUCCESS x265-3.5-GCCcore-11.2.0.eb
• SUCCESS SeqAn-2.4.0-GCCcore-10.2.0.eb
• SUCCESS protobuf-3.17.3-GCCcore-10.3.0.eb
• SUCCESS openCARP-8.2-foss-2021a.eb

Build succeeded for 11 out of 11 (11 easyconfigs in total)
node3141.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/bac36269febec41849dc1b07e73fdb93 for a full test report.

[Micket]

@boegel Hm, i just realized this leads the situation that you need to specify something in the runtest part, else testing won't be considered.
Perhaps change this to

if self.cfg['runtest'] or self.cfd['test_cmd'] != DEFAULT_TEST_CMD:

Otherwise you'd have to do possibly silly things:

test_cmd = './tests.sh'
runtest = ' ' # only to trigger the tests

or

test_cmd = 'ctest'
runtest = '-j'  # add one flag here or something to make it actually run.

[boegel]

@Micket Makes sense, please open a PR for that ASAP, maybe (just maybe) we can still include this into EasyBuild v4.5.5

[boegel]

followed up in #2737