enhance MrBayes easyblock with custom sanity check command

[jfgrimm]

(created using eb --new-pr)

[ocaisa]

I tried this out but I don't see these checks being run:

== sanity checking...
  >> file 'bin/mb' found: OK
  >> (non-empty) directory 'share' found: OK
  >> loading modules: MrBayes/3.2.7-gompi-2020b...
== ... (took 4 secs)```

[ocaisa]

I think you need to use enhance_sanity_check = True in the easyconfig, but that then kicks an error because there is no lib directory

[jfgrimm]

@ocaisa I can't reproduce that
If I run eb --include-easyblocks-from-pr=2727 MrBayes-3.2.7-gompi-2020b.eb --robot --rebuild I see:

== sanity checking...
  >> file 'bin/mb' found: OK
  >> (non-empty) directory 'share' found: OK
  >> loading modules: bio/MrBayes/3.2.7-gompi-2020b...
  >> running command 'mb -help' ...
  >> result for command 'mb -help': OK

[ocaisa]

That's because the old ec has an explicit sanity check command mb -help included (note the missing one with about)

[jfgrimm]

Oh I see, that easyconfig actually doesn't use the MrBayes easyblock, it's just a ConfigureMake

[jfgrimm]

@ocaisa can you try with one of the MrBayes easyconfigs that uses the easyblocks? eg eb --from-pr 15568 --include-easyblocks-from-pr=2727 --rebuild --robot

[ocaisa]

@jfgrimm I tried this easyblock with 3.2.7 and it doesn't work. I wonder if there is much point changing the easyblock now given that the latest versions of MrBayes are not supported anyway (and instead use a ConfigureMake easyblock)?

[jfgrimm]

I mean, there's a PR for 3.2.6 so I assume there's a requirement for that version. Since 3.2.7+ doesn't use the easyblock and instead uses ConfigureMake, I don't see why that matters here?

[ocaisa]

What I mean is, is there much point in adding features to a now-outdated easyblock?

I would say that the version in that PR should really be 3.2.7a

[ocaisa]

I looked at the discussion in https://github.com/easybuilders/easybuild-easyconfigs/pull/10831/files#r443527147 and I think we can merge that PR with a small change here:

    def __init__(self, *args, **kwargs):
        super(EB_MrBayes, self).__init__(*args, **kwargs)
        # For later MrBayes versions, no longer need to use this easyblock
        last_supported_version = '3.2.6'
        if LooseVersion(self.version) > LooseVersion(last_supported_version):
            raise EasyBuildError("Please use the ConfigureMake easyblock for %s versions > %s", self.name,
                                 last_supported_version)

(I tested this)

[ocaisa]

With the new __init__() this would be good to go for me. I will already merge easybuilders/easybuild-easyconfigs#10831 and then suggest in the other PR to base off that version

[boegel]

Test report by @boegel

Overview of tested easyconfigs (in order)

• SUCCESS MrBayes-3.2.6-gompi-2020b.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3101.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/ae9f582c9d1d235f12d5abc6ac09ead5 for a full test report.