Skip to content

Conversation

@boegel
Copy link
Member

@boegel boegel commented Aug 6, 2022

Follow-up for #2514 by @Flamefire, which takes into account that:

det_cmake_version produces a clean error message if the CMake version could not be determined (for example if the cmake command is not found)

@casparvl
Copy link
Contributor

casparvl commented Aug 9, 2022

Test report by @casparvl

Overview of tested easyconfigs (in order)

  • SUCCESS snappy-1.1.8-GCCcore-10.3.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
tcn1 - Linux RHEL 8.4, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/d9c48b9db80f34a58ee9699f9e8c1f50 for a full test report.

@casparvl
Copy link
Contributor

casparvl commented Aug 9, 2022

Test report by @casparvl

Overview of tested easyconfigs (in order)

  • SUCCESS snappy-1.1.8-GCCcore-10.3.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
tcn1 - Linux RHEL 8.4, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/bc0abe1305f52d68c80671e92d8e26a7 for a full test report.

casparvl
casparvl previously approved these changes Aug 9, 2022
Copy link
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I've tested with snappy (which uses CMakeMake) with and without --filter-deps=CMake. Both builds completed successfully, and both builds did not set things like CMAKE_CXX_FLAGS, indicating that they took the correct code path when evaluating:

if LooseVersion(cmake_version) < LooseVersion('2.8.0') or cache_exists:

I see @Flamefire is more critical on the tests though. So, I'll leave this open. @Flamefire once you're happy too, feel free to hit merge :)

@boegel
Copy link
Member Author

boegel commented Sep 9, 2022

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Z3-4.8.16-GCCcore-11.3.0.eb
  • SUCCESS pybind11-2.6.2-GCCcore-10.3.0.eb
  • SUCCESS kallisto-0.48.0-gompi-2021b.eb
  • SUCCESS netCDF-4.8.1-iimpi-2021b.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
node3114.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/e45bf82c602358979b0f4f73b84e8d8a for a full test report.

Copy link
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm this one had sufficient eyes on it and looks good to me too

@bartoldeman bartoldeman merged commit ba43a75 into easybuilders:develop Sep 10, 2022
@boegel boegel deleted the cmake_version branch September 10, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants