-
Notifications
You must be signed in to change notification settings - Fork 306
use det_cmake_version function to determine CMake version in CMakeMake generic easyblock #2772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e generic easyblock
|
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
|
Test report by @casparvl Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I've tested with snappy (which uses CMakeMake) with and without --filter-deps=CMake. Both builds completed successfully, and both builds did not set things like CMAKE_CXX_FLAGS, indicating that they took the correct code path when evaluating:
if LooseVersion(cmake_version) < LooseVersion('2.8.0') or cache_exists:
I see @Flamefire is more critical on the tests though. So, I'll leave this open. @Flamefire once you're happy too, feel free to hit merge :)
…det_cmake_version
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (4 easyconfigs in total) |
bartoldeman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm this one had sufficient eyes on it and looks good to me too
Follow-up for #2514 by @Flamefire, which takes into account that:
Noneis fed toLooseVersion(cfr. reduce the number of command line options for 'cmake' command in CMakeMake generic easyblock #2514 (comment))cmakein OS is preferred insteaddet_cmake_versionproduces a clean error message if the CMake version could not be determined (for example if thecmakecommand is not found)