remove useless -openmp build option for MRtrix v3.x #2822
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the openmp build flag as MRtrix itself does not contain any OpenMP code. Using the flag led to issues with unresolved omp symbols however.
See https://community.mrtrix.org/t/error-population-template-undefined-symbol-omp-get-max-threads/6128/7 for a description of the issue.
I assume the issue is caused by a missing -fopenmp flag on some linker steps in the MRtrix build process. And since no direct OpenMP calls are made in the code it is upon the compiler to decide to actually link OpenMP, or not.
But since MRtrix does not support OpenMP directly it may be better to not use the flag at all.