Skip to content

remove useless -openmp build option for MRtrix v3.x #2822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 24, 2022

Conversation

FokkeDijkstra
Copy link
Contributor

Removed the openmp build flag as MRtrix itself does not contain any OpenMP code. Using the flag led to issues with unresolved omp symbols however.

See https://community.mrtrix.org/t/error-population-template-undefined-symbol-omp-get-max-threads/6128/7 for a description of the issue.

I assume the issue is caused by a missing -fopenmp flag on some linker steps in the MRtrix build process. And since no direct OpenMP calls are made in the code it is upon the compiler to decide to actually link OpenMP, or not.
But since MRtrix does not support OpenMP directly it may be better to not use the flag at all.

OpenMP code. Using the flag led to issues with unresolved omp symbols
however.
@boegel boegel changed the title Removed openmp build flag for MRtrix remove -openmp build option for MRtrix v3.x Nov 9, 2022
@boegel boegel added this to the next release (4.6.3?) milestone Nov 9, 2022
@boegel
Copy link
Member

boegel commented Dec 22, 2022

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS MRtrix-3.0-rc-20191217-foss-2019b-Python-2.7.16.eb
  • SUCCESS MRtrix-3.0-rc-20191217-foss-2019b-Python-3.7.4.eb
  • SUCCESS MRtrix-3.0.0-foss-2020a-Python-3.8.2.eb
  • SUCCESS MRtrix-3.0.3-foss-2021a.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
node3136.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/e1ed41b0932844f0575f1763b8e0f76a for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 64a96e2 into easybuilders:develop Dec 24, 2022
@boegel boegel changed the title remove -openmp build option for MRtrix v3.x remove useless -openmp build option for MRtrix v3.x Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants