Skip to content

add generic Dataset easyblock #3246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

smoors
Copy link
Contributor

@smoors smoors commented Mar 3, 2024

(created using eb --new-pr)

depends on framework PR:

now also implements an "object storage" as suggested by @boegel . things i’m not sure about:

  • currently uses symlinks to files in the object storage. should i use hardlinks instead, or add an option for it?
  • the object storage is not required to get a working installation. should i add an option for it?

@jfgrimm
Copy link
Member

jfgrimm commented May 16, 2024

reminder for myself to revisit RELION once this is merged: easybuilders/easybuild-easyconfigs#19678

@jfgrimm jfgrimm modified the milestones: 4.x, 5.x Apr 7, 2025
@boegel boegel modified the milestones: 5.x.x, 5.x Apr 9, 2025
@smoors smoors modified the milestones: 5.x, release after 5.0.0 Apr 18, 2025
jfgrimm
jfgrimm previously requested changes May 7, 2025
Copy link
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor code cleanup now that we dropped python2 support

@boegel boegel modified the milestones: 5.x, 5.0.1 May 7, 2025
@smoors
Copy link
Contributor Author

smoors commented May 8, 2025

successful test report: easybuilders/easybuild-easyconfigs#20019 (comment)

@akesandgren
Copy link
Contributor

Test report by @akesandgren

Overview of tested easyconfigs (in order)

  • SUCCESS RFdiffusion-schedules-1.1.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
b-cn1611.hpc2n.umu.se - Linux Ubuntu 22.04, x86_64, AMD EPYC 7313 16-Core Processor, 1 x NVIDIA NVIDIA A100 80GB PCIe, 555.58.02, Python 3.10.12
See https://gist.github.com/akesandgren/69fadb8c47093d750a521896d489173b for a full test report.

@akesandgren akesandgren dismissed stale reviews from jfgrimm and themself May 9, 2025 09:18

Requested change committed

@akesandgren
Copy link
Contributor

Going in, thanks @smoors!

@akesandgren akesandgren merged commit aa044df into easybuilders:develop May 9, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants