Skip to content

adopt module_load_environment in AOCC easyblock + fix compatibility with --module-only #3594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 17, 2025
Merged

adopt module_load_environment in AOCC easyblock + fix compatibility with --module-only #3594

merged 3 commits into from
Feb 17, 2025

Conversation

boegel
Copy link
Member

@boegel boegel commented Feb 13, 2025

(created using eb --new-pr)

@boegel boegel mentioned this pull request Feb 13, 2025
Closed
82 tasks
@boegel boegel added change EasyBuild-5.0 EasyBuild 5.0 labels Feb 13, 2025
@boegel boegel added this to the 5.0 milestone Feb 13, 2025
@boegel boegel force-pushed the 20250213085943_new_pr_aocc branch 2 times, most recently from 27ca1cc to 9419bef Compare February 13, 2025 11:04
@boegel boegel force-pushed the 20250213085943_new_pr_aocc branch from 9419bef to adf21d8 Compare February 13, 2025 11:06
@boegel
Copy link
Member Author

boegel commented Feb 13, 2025

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS AOCC-2.3.0-GCCcore-10.2.0.eb
  • SUCCESS AOCC-3.0.0-GCCcore-10.2.0.eb
  • SUCCESS AOCC-3.0.0-GCCcore-10.3.0.eb
  • SUCCESS AOCC-3.1.0-GCCcore-10.2.0.eb
  • SUCCESS AOCC-3.1.0-GCCcore-10.3.0.eb
  • SUCCESS AOCC-3.1.0-GCCcore-11.2.0.eb
  • SUCCESS AOCC-3.2.0-GCCcore-11.2.0.eb
  • SUCCESS AOCC-3.2.0-GCCcore-11.3.0.eb
  • SUCCESS AOCC-4.0.0-GCCcore-11.3.0.eb
  • SUCCESS AOCC-4.0.0-GCCcore-12.2.0.eb
  • SUCCESS AOCC-4.0.0-GCCcore-12.3.0.eb
  • SUCCESS AOCC-4.2.0-GCCcore-13.3.0.eb

Build succeeded for 12 out of 12 (12 easyconfigs in total)
node3561.doduo.os - Linux RHEL 8.8, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegel/cfacc2dda5e3473ab72c90e9a23b73ec for a full test report.

@boegel boegel changed the title adopt module_load_environment in AOCC easyblock + fix compatibility with --module-only adopt module_load_environment in AOCC easyblock + fix compatibility with --module-only Feb 13, 2025
@boegel boegel requested a review from lexming February 13, 2025 16:21
lexming
lexming reviewed Feb 13, 2025
View reviewed changes
@boegel
don't hardcode setting $C_INCLUDE_PATH and $CPLUS_INCLUDE_PATH in AOC…
fcaad04 
…C easyblock, leave it up to EasyBuild framework to set $CPATH or $C_INCLUDE_PATH
@boegel
Copy link
Member Author

boegel commented Feb 16, 2025

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS AOCC-2.3.0-GCCcore-10.2.0.eb
  • SUCCESS AOCC-3.0.0-GCCcore-10.2.0.eb
  • SUCCESS AOCC-3.0.0-GCCcore-10.3.0.eb
  • SUCCESS AOCC-3.1.0-GCCcore-10.2.0.eb
  • SUCCESS AOCC-3.1.0-GCCcore-10.3.0.eb
  • SUCCESS AOCC-3.1.0-GCCcore-11.2.0.eb
  • SUCCESS AOCC-3.2.0-GCCcore-11.2.0.eb
  • SUCCESS AOCC-3.2.0-GCCcore-11.3.0.eb
  • SUCCESS AOCC-4.0.0-GCCcore-11.3.0.eb
  • SUCCESS AOCC-4.0.0-GCCcore-12.2.0.eb
  • SUCCESS AOCC-4.0.0-GCCcore-12.3.0.eb
  • SUCCESS AOCC-4.2.0-GCCcore-13.3.0.eb

Build succeeded for 12 out of 12 (12 easyconfigs in total)
node3596.doduo.os - Linux RHEL 8.8, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegel/60dac7ef488bd5a142fdfbb6f11c8f63 for a full test report.

lexming
lexming approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming lexming merged commit 14b7f47 into easybuilders:5.0.x Feb 17, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thyre Thyre Thyre left review comments

@lexming lexming lexming approved these changes

Assignees
No one assigned
Labels
change EasyBuild-5.0 EasyBuild 5.0
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@boegel @lexming @Thyre