enhance Cargo easyblock to handle single-line members in workspaces
#3705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code failed to find members when all are on a single line. E.g.: `members = ["a", "b"]` Fix by splitting the stop condition out of the start-or-append logic so it handles the former. Also show a good error when no members were found instead of crashing due to the access of `None`.
|
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
Micket
approved these changes
Apr 29, 2025
|
It helps with polars - it fix the |
|
Now polars 1.28.1 can be built, many thanks! |
|
There is another PR where I use this fix:
|
|
@pavelToman Can you provide test reports for this PR with those? I.e. |
|
I am trying, but --inject-checksums does not work for CargoPythonBundle and CI check wants checksums... |
|
SCENICplus PR is OK, scatac_fragment_tools can be built with this patch: |
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 72 out of 72 (71 easyconfigs in total) |
boegel
changed the title
Cargo easyblock to handle single-line members in workspaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code failed to find members when all are on a single line. E.g.:
members = ["a", "b"]Fix by splitting the stop condition out of the start-or-append logic so it handles the former.
Also show a good error when no members were found instead of crashing due to the access of
None.