-
Notifications
You must be signed in to change notification settings - Fork 294
add custom easyblock for Term::ReadLine::Gnu
Perl module
#3712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add custom easyblock for Term::ReadLine::Gnu
Perl module
#3712
Conversation
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Term::ReadLine::Gnu
Perl module
Term::ReadLine::Gnu
Perl moduleTerm::ReadLine::Gnu
Perl module
@boegelbot please test @ jsc-zen3 |
@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2895491781 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 3 (3 easyconfigs in total) |
Hmm, test failure has nothing to do with this custom easyblock I think, I'll look into it...
|
Can we get a backtrace of that error? Because it should be set by: |
The problem is introduced with the changes in easybuilders/easybuild-framework#4868, where the check for The custom easyblock for Perl sets I'll open a PR to fix that regression... |
FWIW: Why do we do that check there anyway? Couldn't we just fail if and only if we required that? Imagine a bundle of extensions each having a custom easyblock and/or explicit easyblock. Why require Just remembered I actually had a PR for that already: easybuilders/easybuild-framework#4800 |
I've opened easybuilders/easybuild-framework#4888 to fix the regression, since the changes in easybuilders/easybuild-framework#4800 are a lot more involved and are beyond what I still what to consider for including in the upcoming EasyBuild v5.1.0 release at this point... |
@boegelbot please test @ jsc-zen3 |
@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2897143045 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
(created using
eb --new-pr
)Without any of
--prefix --libdir --incdir
the "configure" script might pick up a system libreadline which might then fail the test withNeither passing additional
-L
parameters viaLDFLAGS
nor the already setLIBRARY_PATH
avoided that because there is a custom search procedure adding additional-L
flags to e.g./usr/lib64
since it searcheslibpth
set by Perl itself (determined during the core Perl module configure), seeperl -V