allow downloaded Python packages if implicitely requested #3722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When not using `pip --no-deps` depencencies will be downloaded. Similar when using a requirements file downloads are also expected. Adjust the default for `download_dep_fail` accordingly.
Flamefire
force-pushed
the
download_dep_fail-pypackage
branch
from
5430974 to
b8cd571
Compare
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When not using
pip --no-depsdepencencies will be downloaded. Similar when using a requirements file downloads are also expected.Adjust the default for
download_dep_failaccordingly.This is basically a regression in 5.0 which changed the default from
FalsetoTrue