-
Notifications
You must be signed in to change notification settings - Fork 308
add missing call to make_module_step for components in Bundle easyblock
#3801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing call to make_module_step for components in Bundle easyblock
#3801
Conversation
When EasyBlocks are not using the deprecated `make_module_req_guess`, the Bundle EasyBlock would only collect the `module_load_environment` set outside of `make_module_step`. `make_module_step` was never called by Bundle, and hence additional module paths were missing. To fix this, also run the `module` step for each component. Signed-off-by: Jan André Reuter <[email protected]>
|
Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (3 easyconfigs in total) |
|
Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 0 out of 3 (3 easyconfigs in total) Still fails |
Call `make_module_step` for each component explicitly in Bundles own `make_module_step`, since step list in `install_step` will not be executed in a module-only build. Signed-off-by: Jan André Reuter <[email protected]>
|
Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (3 easyconfigs in total) |
|
Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
|
Looking at this For the deprecated approach, we call easybuild-easyblocks/easybuild/easyblocks/generic/bundle.py Lines 336 to 351 in 70bab62
Are there any EasyConfigs we could test this with? |
Also sets fake=True for both calls to avoid multiple modules with the same name being created during the install process. This should shouldn't have broken something, it's simply cleaner. Signed-off-by: Jan André Reuter <[email protected]>
|
Rebuild: Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (4 easyconfigs in total) |
|
Module only: Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (4 easyconfigs in total) Interestingly, I need to check if this is because of this PR. Edit: Also occurs without this PR. |
|
@boegelbot please test @ jsc-zen3 |
|
@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3010092357 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 7 out of 8 (8 easyconfigs in total) |
|
@boegelbot please test @ jsc-zen3 |
|
@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3011700918 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 2 (2 easyconfigs in total) |
Where is I'll cross-check on |
[reuter1@jsczen3l1 ~]$ module list
No modules loaded
[reuter1@jsczen3l1 ~]$ pip check
No broken requirements found.
[reuter1@jsczen3l1 ~]$ module load Python/3.11.3
[reuter1@jsczen3l1 ~]$ module list
Currently Loaded Modules:
1) GCCcore/12.3.0 3) binutils/2.40-GCCcore-12.3.0 5) ncurses/6.4-GCCcore-12.3.0 7) Tcl/8.6.13-GCCcore-12.3.0 9) XZ/5.4.2-GCCcore-12.3.0 11) OpenSSL/1.1
2) zlib/1.2.13-GCCcore-12.3.0 4) bzip2/1.0.8-GCCcore-12.3.0 6) libreadline/8.2-GCCcore-12.3.0 8) SQLite/3.42.0-GCCcore-12.3.0 10) libffi/3.4.4-GCCcore-12.3.0 12) Python/3.11.3-GCCcore-12.3.0
[reuter1@jsczen3l1 ~]$ pip list
Package Version
----------------- -------
flann 1.9.2
flann 1.9.2
flit_core 3.9.0
packaging 23.1
pip 23.1.2
setuptools 67.7.2
setuptools-rust 1.11.1
setuptools-scm 7.1.0
tomli 2.0.1
typing_extensions 4.6.3
wheel 0.40.0
[notice] A new release of pip is available: 23.1.2 -> 25.1.1
[notice] To update, run: pip install --upgrade pip
[reuter1@jsczen3l1 ~]$ pip check
setuptools-rust 1.11.1 requires semantic-version, which is not installed.I haven't touched |
|
Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
|
@boegelbot please test @ jsc-zen3 |
|
@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3012235149 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (3 easyconfigs in total) |
|
Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 8 out of 8 (8 easyconfigs in total) |
Co-authored-by: ocaisa <[email protected]>
make_module_step for componentsmake_module_step for components in Bundle easyblock
|
@boegelbot please test @ jsc-zen3 |
|
@ocaisa: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3028000072 processed Message to humans: this is just bookkeeping information for me, |
ocaisa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Certainly in principle these changes look fine to me, tests have not thrown up any problems AFAICT
|
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (3 easyconfigs in total) |
|
Thanks a lot for figuring this out @Thyre! |
When EasyBlocks are not using the deprecated
make_module_req_guess, the Bundle EasyBlock would only collect themodule_load_environmentset outside ofmake_module_step.make_module_stepwas never called by Bundle, and hence additional module paths were missing.To fix this, also run the
make_modulestep for each component.Fixes #3800