X11-20201008-GCCcore-10.2.0.eb fails at installing bundle component

[Mormacill]

== processing EasyBuild easyconfig /home/easybuilder/.local/EasyBuildInst/software/EasyBuild/4.3.2/easybuild/easyconfigs/x/X11/X11-20201008-GCCcore-10.2.0.eb
== building and installing X11/20201008-GCCcore-10.2.0...
== fetching files...
== creating build dir, resetting environment...
== unpacking...
== patching...
== preparing...
== configuring...
== building...
== testing...
== installing...
== installing bundle component libpthread-stubs v0.4 (1/49)...
== installing bundle component xorgproto v2020.1 (2/49)...
== installing bundle component libXau v1.0.9 (3/49)...
== installing bundle component libXdmcp v1.1.3 (4/49)...
== installing bundle component xcb-proto v1.14.1 (5/49)...
== installing bundle component libxcb v1.14 (6/49)...
== installing bundle component xtrans v1.4.0 (7/49)...
== installing bundle component libxkbcommon v1.0.1 (8/49)...
== installing bundle component libX11 v1.6.12 (9/49)...
== installing bundle component libXext v1.3.4 (10/49)...
== installing bundle component libFS v1.0.8 (11/49)...
== installing bundle component libICE v1.0.10 (12/49)...
== installing bundle component libSM v1.2.3 (13/49)...
== installing bundle component libXScrnSaver v1.2.3 (14/49)...
== installing bundle component libXt v1.2.0 (15/49)...
== installing bundle component libXmu v1.1.3 (16/49)...
== installing bundle component libXpm v3.5.13 (17/49)...
== installing bundle component libXaw v1.0.13 (18/49)...
== installing bundle component libXfixes v5.0.3 (19/49)...
== installing bundle component libXcomposite v0.4.5 (20/49)...
== installing bundle component libXrender v0.9.10 (21/49)...
== installing bundle component libXcursor v1.2.0 (22/49)...
== installing bundle component libXdamage v1.1.5 (23/49)...
== installing bundle component libfontenc v1.1.4 (24/49)...
== installing bundle component libXfont v1.5.4 (25/49)...
== installing bundle component libXfont2 v2.0.4 (26/49)...
== FAILED: Installation ended unsuccessfully (build directory: /home/easybuilder/.local/easybuild/build/X11/20201008/GCCcore-10.2.0): build failed (first 300 chars): cmd " make -j 4 " exited with exit code 2 and output:
make  all-recursive
make[1]: Entering directory '/home/easybuilder/.local/easybuild/build/X11/20201008/GCCcore-10.2.0/libXfont2-2.0.4'
Making all in doc
make[2]: Entering directory '/home/easybuilder/.local/easybuild/build/X11/20201008/GCCcore-10 (took 5 min 21 sec)
== Results of the build can be found in the log file(s) /tmp/eb-dpola5hi/easybuild-X11-20201008-20210118.004614.hNBJO.log
ERROR: Build of /home/easybuilder/.local/EasyBuildInst/software/EasyBuild/4.3.2/easybuild/easyconfigs/x/X11/X11-20201008-GCCcore-10.2.0.eb failed (err: 'build failed (first 300 chars): cmd " make -j 4 " exited with exit code 2 and output:\nmake  all-recursive\nmake[1]: Entering directory \'/home/easybuilder/.local/easybuild/build/X11/20201008/GCCcore-10.2.0/libXfont2-2.0.4\'\nMaking all in doc\nmake[2]: Entering directory \'/home/easybuilder/.local/easybuild/build/X11/20201008/GCCcore-10')

This only happens at bundle component libXfont2 v2.0.4, disabling it in config will result in successfull build.
Full log:
https://gist.github.com/Mormacill/0fb0700fde050660875ed831213fb9da

[Mormacill]

As I found out this only occurs on Ubuntu, building on Centos succeds.

[boegel]

Here's the relevant part of the log:

== 2021-01-18 00:51:35,591 run.py:222 INFO running cmd:  make -j 4  
== 2021-01-18 00:51:36,446 build_log.py:169 ERROR EasyBuild crashed with an error (at easybuild/base/exceptions.py:124 in __init__): cmd " make -j 4 " exited with exit code 2 and output:
make  all-recursive
make[1]: Entering directory '/home/easybuilder/.local/easybuild/build/X11/20201008/GCCcore-10.2.0/libXfont2-2.0.4'
Making all in doc
make[2]: Entering directory '/home/easybuilder/.local/easybuild/build/X11/20201008/GCCcore-10.2.0/libXfont2-2.0.4/doc'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/home/easybuilder/.local/easybuild/build/X11/20201008/GCCcore-10.2.0/libXfont2-2.0.4/doc'
make[2]: Entering directory '/home/easybuilder/.local/easybuild/build/X11/20201008/GCCcore-10.2.0/libXfont2-2.0.4'
  CC       src/stubs/atom.lo
  CC       src/stubs/libxfontstubs.lo
  CC       src/util/fontaccel.lo
  CC       src/util/fontnames.lo
  CC       src/util/fontutil.lo
  CC       src/util/fontxlfd.lo
  CC       src/util/format.lo
  CC       src/util/miscutil.lo
src/util/fontxlfd.c: In function 'append_ranges':
src/util/fontxlfd.c:361:9: error: implicit declaration of function 'strlcat'; did you mean 'strncat'? [-Werror=implicit-function-declaration]
  361 |         strlcat(fname, "[", fnamelen);
      |         ^~~~~~~
      |         strncat
src/util/fontxlfd.c:361:9: warning: nested extern declaration of 'strlcat' [-Wnested-externs]
src/util/fontxlfd.c: In function 'FontParseXLFDName':
src/util/fontxlfd.c:453:2: error: implicit declaration of function 'strlcpy'; did you mean 'strncpy'? [-Werror=implicit-function-declaration]
  453 |  strlcpy(tmpBuf, ptr2, sizeof(tmpBuf));
      |  ^~~~~~~
      |  strncpy
src/util/fontxlfd.c:453:2: warning: nested extern declaration of 'strlcpy' [-Wnested-externs]
  CC       src/util/patcache.lo
  CC       src/util/private.lo
cc1: some warnings being treated as errors
Makefile:995: recipe for target 'src/util/fontxlfd.lo' failed
make[2]: *** [src/util/fontxlfd.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/home/easybuilder/.local/easybuild/build/X11/20201008/GCCcore-10.2.0/libXfont2-2.0.4'
Makefile:1067: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/home/easybuilder/.local/easybuild/build/X11/20201008/GCCcore-10.2.0/libXfont2-2.0.4'
Makefile:643: recipe for target 'all' failed
make: *** [all] Error 2
 (at easybuild/tools/run.py:533 in parse_cmd_output)

This looks like a problem due to a recent glibc version to me?

cc @zao @akesandgren

[zao]

strlcat comes from libbsd-dev on Ubuntu, it's not in glibc.

On my machine the package is not installed and libXfont2 seems to also ship a private implementation of the function. The solution is probably to patch the source file(s) to include the correct header based on what configure decided.

The underlying problem has probably always been around, but may have been promoted to an error in recent GCC versions.

[terjekv]

Confirmed that removing libbsd[-devel] on RHEL8 "resolved" the issue.

[bluedominion]

I was having this exact same problem on Ubuntu 18.04. Managed to get it to install without issue by changing the libXfont2 version from 2.0.4 -> 2.0.3 Installed without issue after making that change and updating the checksums.

[boegel]

Upstream issue: https://gitlab.freedesktop.org/xorg/lib/libxfont/-/issues/11
Patch to fix the problem: https://gitlab.freedesktop.org/xorg/lib/libxfont/-/commit/ce7a3265019e4d66198c1581d9e8c859c34e8ef1.patch