Skip to content

{devel}[system] ReFrame v3.0 #10754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 10, 2020
Merged

{devel}[system] ReFrame v3.0 #10754

merged 10 commits into from
Jun 10, 2020

Conversation

teojgo
Copy link
Contributor

@teojgo teojgo commented Jun 5, 2020

The recipe needs this fix: easybuilders/easybuild-easyblocks#2075 for the PythonBundle easyblock to work correctly.

@boegel boegel changed the title Add EasyBuild recipe for ReFrame 3.0 {devel}[system] ReFrame v3.0 Jun 8, 2020
@easybuilders easybuilders deleted a comment from boegelbot Jun 9, 2020

exts_list = [
('setuptools', '47.1.1', {
'source_tmpl': 'setuptools-47.1.1.zip',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teojgo Please use %(version)s here to avoid hardcoding the setuptools version in two places:

Suggested change
'source_tmpl': 'setuptools-47.1.1.zip',
'source_tmpl': 'setuptools-%(version)s.zip',

@boegel
Copy link
Member

boegel commented Jun 9, 2020

@teojgo Not working for me currently:

== installing extension zipp 3.1.0 (2/8)...
== FAILED: Installation ended unsuccessfully (build directory: /tmp/kehoste/ReFrame/3.0/system-system): build failed (first 300 chars): cmd " /usr/bin/python3 setup.py build " exited with exit code 1 and output:
WARNING: The wheel package is not available.
ERROR: 'pip wheel' requires the 'wheel' package. To fix this, run: pip install wheel

@teojgo
Copy link
Contributor Author

teojgo commented Jun 9, 2020

@teojgo Not working for me currently:

== installing extension zipp 3.1.0 (2/8)...
== FAILED: Installation ended unsuccessfully (build directory: /tmp/kehoste/ReFrame/3.0/system-system): build failed (first 300 chars): cmd " /usr/bin/python3 setup.py build " exited with exit code 1 and output:
WARNING: The wheel package is not available.
ERROR: 'pip wheel' requires the 'wheel' package. To fix this, run: pip install wheel

@boegel can you check now? Should I include pip as well in the exts_list?

@boegel
Copy link
Member

boegel commented Jun 9, 2020

@teojgo Not working for me currently:

== installing extension zipp 3.1.0 (2/8)...
== FAILED: Installation ended unsuccessfully (build directory: /tmp/kehoste/ReFrame/3.0/system-system): build failed (first 300 chars): cmd " /usr/bin/python3 setup.py build " exited with exit code 1 and output:
WARNING: The wheel package is not available.
ERROR: 'pip wheel' requires the 'wheel' package. To fix this, run: pip install wheel

@boegel can you check now? Should I include pip as well in the exts_list?

I think you should add pip too, yes, and then you might as well enable the use of pip for the extensions, and only disable it for setuptools and pip itself?

@teojgo
Copy link
Contributor Author

teojgo commented Jun 9, 2020

@teojgo Not working for me currently:

== installing extension zipp 3.1.0 (2/8)...
== FAILED: Installation ended unsuccessfully (build directory: /tmp/kehoste/ReFrame/3.0/system-system): build failed (first 300 chars): cmd " /usr/bin/python3 setup.py build " exited with exit code 1 and output:
WARNING: The wheel package is not available.
ERROR: 'pip wheel' requires the 'wheel' package. To fix this, run: pip install wheel

@boegel can you check now? Should I include pip as well in the exts_list?

I think you should add pip too, yes, and then you might as well enable the use of pip for the extensions, and only disable it for setuptools and pip itself?

If I do include pip and enable use_pip = True then I get this problem, :

cmd "pip --version" exited with exit code 32 and output:
.
.
.
UserWarning: Setuptools no longer works on Python 2

@boegel
Copy link
Member

boegel commented Jun 9, 2020

@teojgo Can you share the full easyconfig?

add pip extension + use it for installing extensions, add missing six extension
@teojgo
Copy link
Contributor Author

teojgo commented Jun 9, 2020

@boegel, I have checked it with the change in easybuilders/easybuild-easyblocks#2075 and it installs fine.

@boegel
Copy link
Member

boegel commented Jun 9, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3402.kirlia.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz (cascadelake), Python 2.7.5
See https://gist.github.com/c0bb38991612d14e65ad70360113d1d3 for a full test report.

@boegel
Copy link
Member

boegel commented Jun 9, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
generoso - Linux centos linux 8.1.1911, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/0085633010c6fe46d5425cc80885d818 for a full test report.

@boegel
Copy link
Member

boegel commented Jun 9, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3100.skitty.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/fefe1f30b0cb32a029956b13e4e8e169 for a full test report.

@easybuilders easybuilders deleted a comment from boegelbot Jun 9, 2020
@boegel
Copy link
Member

boegel commented Jun 10, 2020

Going in, thanks @teojgo!

@boegel boegel merged commit 94e6803 into easybuilders:develop Jun 10, 2020
@boegel boegel modified the milestones: 4.x, next release (4.2.2?) Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants