Skip to content

rename sdsl-lite to SDSL (to use one single name) #11084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lexming merged 10 commits into from
Aug 28, 2020
Merged

rename sdsl-lite to SDSL (to use one single name) #11084

lexming merged 10 commits into from
Aug 28, 2020

Conversation

@mboisson
Copy link
Contributor

@mboisson mboisson commented Aug 10, 2020

No description provided.

@mboisson
Copy link
Contributor Author

mboisson commented Aug 10, 2020

This PR has some commits which are shared with #11082

smoors
smoors previously requested changes Aug 11, 2020
View reviewed changes
@mboisson mboisson mentioned this pull request Aug 12, 2020
Closed
@boegel boegel changed the title Rename sdsl rename sdsl-lite to SDSL (to use one single name) Aug 18, 2020
@easybuilders easybuilders deleted a comment from boegelbot Aug 18, 2020
@easybuilders easybuilders deleted a comment from boegelbot Aug 18, 2020
@boegel
Copy link
Member

boegel commented Aug 18, 2020

@mboisson This needs a sync with develop now that #11082 is merged?

@mboisson
Copy link
Contributor Author

mboisson commented Aug 18, 2020

I don't think it did, since commits were cherry-picked between the two. But I did it anyway.

@mboisson mboisson mentioned this pull request Aug 20, 2020
Closed
@lexming
Copy link
Contributor

lexming commented Aug 28, 2020

Test report by @lexming
SUCCESS
Build succeeded for 4 out of 4 (2 easyconfigs in this PR)
node368.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/90e6101771d7b8c3da28f287e161dd0f for a full test report.

@lexming
Copy link
Contributor

lexming commented Aug 28, 2020

Test report by @lexming
SUCCESS
Build succeeded for 4 out of 4 (2 easyconfigs in this PR)
node126.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz, Python 2.7.5
See https://gist.github.com/d9718fce5b425af56c8ab1edc5c8e90a for a full test report.

lexming
lexming approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming lexming added the change label Aug 28, 2020
@lexming lexming added this to the next release (4.3.0) milestone Aug 28, 2020
@lexming lexming dismissed smoors’s stale review August 28, 2020 14:25

review addressed by author

@lexming
Copy link
Contributor

lexming commented Aug 28, 2020

Going in, thanks @mboisson !

@lexming lexming merged commit 0c5d6d8 into easybuilders:develop Aug 28, 2020
@mboisson mboisson deleted the rename-SDSL branch September 1, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lexming lexming lexming approved these changes

@smoors smoors smoors left review comments

Assignees

No one assigned

Labels

change

Projects

None yet

Milestone

4.3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mboisson @boegel @lexming @smoors