stop using 'remove_usr_bin'-patch in TensorFlow easyconfig, no longer required with updated TensorFlow easyblock

[Flamefire]

Handled by the EasyBlock now in a more general way

Follow-up to easybuilders/easybuild-easyblocks#2110

Note: For 1.12.0 the patch is still there but I considered them too old (2018b toolchain)

[smoors]

@boegelbot please test @ generoso

[boegel]

@Flamefire Even though the patches are no longer used, we shouldn't remove them yet...

People may have their own customized TensorFlow easyconfig which still use the patch, and may rely on EasyBuild providing it.

For the next major EasyBuild release we'll do a cleanup swipe of unused patches, and remove them then in a single go...

[Flamefire]

Readded the patch and adjusted the commit message

[boegel]

Test report by @boegel
SUCCESS
Build succeeded for 16 out of 16 (16 easyconfigs in this PR)
node3123.skitty.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/4557dcaed20ffc3f4b1604646866efed for a full test report.

[boegel]

That test report was only with eb --fetch, to make sure auto-downloading didn't get broken.

Full test report with actual installations coming up (but it'll take a while...)

[boegel]

@smoors I've cancelled the job submitted by @boegelbot, there's too much dependencies missing, it'll take forever.

I'll install the missing deps centrally first on generoso, and then let the bot re-try...

[boegel]

@boegelbot please test @ generoso

[boegelbot]

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11087 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11087 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

• exit code: 0
• output:

Submitted batch job 5036

Test results coming soon (I hope)...

Details

- notification for comment with ID 674254190 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

[boegel]

Test report by @boegel
SUCCESS
Build succeeded for 16 out of 16 (16 easyconfigs in this PR)
node3303.joltik.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6242 CPU @ 2.80GHz (cascadelake), Python 3.6.8
See https://gist.github.com/43efd4999109d0388bf6bcd7b5282154 for a full test report.

[boegel]

Test report by @boegel
FAILED
Build succeeded for 14 out of 16 (16 easyconfigs in this PR)
node3166.skitty.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/457413cc8b497b837a50b4f402048aa5 for a full test report.

[boegel]

Problems in last test report with the TensorFlow 1.14.0 easyconfigs have been fixed in b3151d9 (the test started running before that commit was added), I'll submit a new test report for just those two easyconfigs to confirm...

[boegel]

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node3101.skitty.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/d5bc9fcc75aa243f7da00f3a3b576006 for a full test report.

[boegel]

Going in, thanks @Flamefire!

[Flamefire]

@boegel although your bot thinks otherwise I'd say it has a bug ;D

[boegel]

@boegel although your bot thinks otherwise I'd say it has a bug ;D

I agree, looking into it... Bad bot!