Skip to content

Conversation

@boegel
Copy link
Member

@boegel boegel commented Aug 11, 2020

(created using eb --new-pr)

@boegel
Copy link
Member Author

boegel commented Aug 11, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2583.golett.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/c30becffa4c5b255d5e3d87670010112 for a full test report.

@boegel
Copy link
Member Author

boegel commented Aug 11, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
generoso - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/e670062b47807e1aa57078f4eb1076ca for a full test report.

@boegel
Copy link
Member Author

boegel commented Aug 11, 2020

I noticed that threadpoolctl was missing when pip check was failing when installing pySCENIC (which depends on scikit-learn, PR coming soon).

It's unclear to me why pip check doesn't barf when installing scikit-learn itself, but I'm guessing that has something to do with not properly registering the dependency (they're using some how grown approach it seems, see https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/_build_utils/min_dependencies.py).

@boegel
Copy link
Member Author

boegel commented Aug 11, 2020

Turns out this was overlooked due to a bug in PythonPackage, see easybuilders/easybuild-easyblocks#2114...

@boegel boegel added the bug fix label Aug 11, 2020
@boegel boegel added this to the next release (4.2.3?) milestone Aug 11, 2020
@boegel
Copy link
Member Author

boegel commented Aug 11, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3411.kirlia.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz (cascadelake), Python 2.7.5
See https://gist.github.com/821e922fb686bb1b3a3dd86c9f78f095 for a full test report.

@boegel
Copy link
Member Author

boegel commented Aug 11, 2020

Last test report was on top of the fixed PythonPackage easyblock rom #2114 (but this PR doesn't require that one).

@boegel
Copy link
Member Author

boegel commented Aug 11, 2020

This is not an issue for previous scikit-learn versions (scikit-learn-0.21.3-foss-2019b-Python-3.7.4.eb for example), because threadpoolctl is a new dependency.

@smoors
Copy link
Contributor

smoors commented Aug 12, 2020

Test report by @smoors
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node254.hydra.os - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2683 v4 @ 2.10GHz (broadwell), Python 2.7.5
See https://gist.github.com/6f7ee46afaa346debb3beec31e069254 for a full test report.

@migueldiascosta
Copy link
Member

Test report by @migueldiascosta
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
sms - Linux centos linux 7.6.1810, x86_64, AMD EPYC 7601 32-Core Processor (zen), Python 2.7.5
See https://gist.github.com/dad76c08cfdd83ef125375ab12044688 for a full test report.

Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Contributor

smoors commented Aug 12, 2020

Going in, thanks @boegel!

@smoors smoors merged commit e39d16b into easybuilders:develop Aug 12, 2020
@boegel boegel deleted the 20200811151828_new_pr_scikit-learn0231 branch August 12, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants